Fixed
Status Update
No update yet.
Comments
sa...@chromium.org
[Empty comment from Monorail migration]
pe...@chromium.org
Tested the issue on reported chrome version #78.0.3904.97 using Windows 10, by the following steps
Steps:
---------
1. Placed caret in front of the first word.
2. Selected word ""Place"" by pressing [Shift] + [Cursor Right]
3. Caret is now at the right side of the selection and pressed [Cursor Down].
4. Observed the entire line is selecting while doing [Shift]+[Cursor Down].
Attached screen-cast for the reference.
@Reporter: Could you please review the attached screencast and let us know if we missed anything from our end. Confirm if this is the issue you are pointing to.
Thanks..
Steps:
---------
1. Placed caret in front of the first word.
2. Selected word ""Place"" by pressing [Shift] + [Cursor Right]
3. Caret is now at the right side of the selection and pressed [Cursor Down].
4. Observed the entire line is selecting while doing [Shift]+[Cursor Down].
Attached screen-cast for the reference.
@Reporter: Could you please review the attached screencast and let us know if we missed anything from our end. Confirm if this is the issue you are pointing to.
Thanks..
ma...@sap.com
No, I don't think the screencast shows the issue I found.
Also, the video and your text do not match. It seems were pressing [Shift]+[Cursor Down] in the video.
The issue is concerning pressing [Cursor Down] only, without Shift. I.e. this is not about extending the selection, but "moving away" from a selection. This "moving away" does not correctly honor if the caret is on the right-hand end of the selection.
Also, the video and your text do not match. It seems were pressing [Shift]+[Cursor Down] in the video.
The issue is concerning pressing [Cursor Down] only, without Shift. I.e. this is not about extending the selection, but "moving away" from a selection. This "moving away" does not correctly honor if the caret is on the right-hand end of the selection.
sh...@chromium.org
Thank you for providing more feedback. Adding the requester to the cc list.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
For more details visit
yo...@chromium.org
Thanks for reporting!
I confirmed behavior mentioned inhttps://crbug.com/chromium/1024774#c1 .
Example:
<div>^abc| def<br>ghi jkl</div>
=> ArrowDown
<div>abc def<br>ghi| jkl</div>
Current:
<div>abc def<br>|ghi jkl</div>
I confirmed behavior mentioned in
Example:
<div>^abc| def<br>ghi jkl</div>
=> ArrowDown
<div>abc def<br>ghi| jkl</div>
Current:
<div>abc def<br>|ghi jkl</div>
[Deleted User] <[Deleted User]>
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visit
pc...@microsoft.com
Still repros. Keeping available.
[Deleted User] <[Deleted User]>
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visit
si...@microsoft.com
I can still repro the issue. Re-marking as available.
is...@google.com
This issue was migrated from crbug.com/chromium/1024774?no_tracker_redirect=1
[Monorail components added to Component Tags custom field.]
[Monorail components added to Component Tags custom field.]
ut...@microsoft.com
ap...@google.com
Project: chromium/src
Branch: main
Author: Utkarsh Pathak <
Link:
Use selection focus for caret position while navigating using arrow keys
Expand for full commit details
Use selection focus for caret position while navigating using arrow keys
While moving cursor up and down, the cursor should come exactly above
and below the previous position respectively. Currently the cursor
position is not correct in these scenarios since we pass
|selection_.Start()| to calculate the x position while editing, instead
we should pass |selection_.Focus()| since focus will be having the last
position of the caret. This change is Firefox compatible.
Updated some existing web_tests that were using selection modifier and
after this CL, the caret position is now changed so these web_tests
needed to adhere to the updated caret positioning.
Updated tests:
web_tests/editing/pasteboard/paste-list-002.html
web_tests/editing/pasteboard/paste-list-003.html
web_tests/editing/pasteboard/paste-list-004.html
web_tests/editing/selection/move-3875618-fix.html
web_tests/editing/inserting/insert-3786362-fix-expected.txt
Bug: 40658856
Change-Id: Id6f00889621003072d7f88bcc00d10f8318ad8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804495
Reviewed-by: Siye Liu <siliu@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Utkarsh Pathak <utpathak@microsoft.com>
Reviewed-by: Sanket Joshi <sajos@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1368113}
Files:
- M
third_party/blink/renderer/core/editing/selection_modifier.cc - M
third_party/blink/renderer/platform/runtime_enabled_features.json5 - M
third_party/blink/web_tests/editing/inserting/insert-3786362-fix-expected.txt - M
third_party/blink/web_tests/editing/pasteboard/paste-list-002.html - M
third_party/blink/web_tests/editing/pasteboard/paste-list-003.html - M
third_party/blink/web_tests/editing/pasteboard/paste-list-004.html - M
third_party/blink/web_tests/editing/selection/move-3875618-fix.html - A
third_party/blink/web_tests/external/wpt/selection/caret-position-should-be-correct-while-moveup-movedown.html
Hash: 1e4c5f5101dc3312f7c0e77dfef65e1248cbe37c
Date: Mon Oct 14 06:07:48 2024
Description
Steps to reproduce the problem:
1. Place caret in front of the first word.
2. Select word "Place" by pressing [Shift] + [Cursor Right] repeatedly.
3. Caret is now at the right side of the selection.
4. Press [Cursor Down].
What is the expected behavior?
5. Caret should be directly below the last caret position ("c" and "t"), but is not. Unexpected. Does not work like majority of text editors. Applies to textarea and contentEditable.
What went wrong?
Compare to 1-3 as above and then pressing [Shift] + [Cursor Down]. Here, the cursor position stays in the same "column".
Did this work before? N/A
Does this work in other browsers? No
Chrome version: 78.0.3904.97 Channel: stable
OS Version: 10.0
Flash Version: