[css-anchor-position-1] Alternative syntax for auto position fallback [40279608]

Fixed

Task

Available

Status Update

No update yet.

Description

ch...@appspot.gserviceaccount.com

created issue #1

Aug 23, 2023 05:37PM

CSSWG added the following resolution(s):

> * `RESOLVED: accept proposal in the draft with details to be worked out over time`

in

https://github.com/w3c/csswg-drafts/issues/9196#issuecomment-1690225805

This issue has been triaged via

https://github.com/chromium-helper/csswg-resolutions/issues/215
If no action is needed, feel free to close this bug. Otherwise, please prioritize the work needed for the above resolutions.

Comments

an...@chromium.org <an...@chromium.org> #2Nov 15, 2023 09:51PM

Stack trace is from V8. Over to Yang.

Received signal 11 SEGV_MAPERR 000000000038
#0 0x7fb8782a211b base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7fb8722e6330 <unknown>
#2 0x7fb8734bba98 v8::internal::JSReceiver::GetKeys()
#3 0x7fb87339ea65 v8::internal::ScopeIterator::CopyContextExtensionToScopeObject()
#4 0x7fb87339caab v8::internal::ScopeIterator::MaterializeLocalScope()
#5 0x7fb87339c1b5 v8::internal::ScopeIterator::ScopeObject()
#6 0x7fb87339bca3 v8::internal::ScopeIterator::MaterializeScopeDetails()
#7 0x7fb8735868cd v8::internal::Runtime_GetAllScopesDetails()
#8 0x15091f208abb <unknown>

an...@chromium.org <an...@chromium.org> #3Nov 15, 2023 10:06PM

I can reproduce. Will work on a fix.

aj...@google.com <aj...@google.com> #4Jan 23, 2024 09:40PM

Fix is underway:

https://codereview.chromium.org/1648263002

aj...@google.com <aj...@google.com> #5Jan 23, 2024 09:46PM

[Empty comment from Monorail migration]

aj...@google.com <aj...@google.com> #6Jan 23, 2024 10:14PM

Thanks for the bug report. Keep them coming :)

aj...@google.com <aj...@google.com> #7Jan 23, 2024 10:15PM

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/835b038331b0fd4d351d9cb5ffbccef186b9919f

commit 835b038331b0fd4d351d9cb5ffbccef186b9919f
Author: yangguo <yangguo@chromium.org>
Date: Mon Feb 01 07:03:09 2016

[debugger] correctly find function context.

In the debugger we are interested in getting the context for the
current frame, which is usually a function context. To do that,
we used to call Context::declaration_context, which may also
return a block context. This is wrong and can lead to crashes.
Instead, we now use a newly introduced Context::closure_context,
which skips block contexts. This works fine for the debugger,
since we have other means to find and materialize block contexts.

R=rossberg@chromium.org
BUG=chromium:582051
LOG=N

Review URL:

https://codereview.chromium.org/1648263002

Cr-Commit-Position: refs/heads/master@{#33627}

[modify]

http://crrev.com/835b038331b0fd4d351d9cb5ffbccef186b9919f/src/contexts.cc
[modify]

http://crrev.com/835b038331b0fd4d351d9cb5ffbccef186b9919f/src/contexts.h
[modify]

http://crrev.com/835b038331b0fd4d351d9cb5ffbccef186b9919f/src/debug/debug-scopes.cc
[modify]

http://crrev.com/835b038331b0fd4d351d9cb5ffbccef186b9919f/src/runtime/runtime-debug.cc
[modify]

http://crrev.com/835b038331b0fd4d351d9cb5ffbccef186b9919f/test/mjsunit/mjsunit.status
[add]

http://crrev.com/835b038331b0fd4d351d9cb5ffbccef186b9919f/test/mjsunit/regress/regress-crbug-582051.js

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #8Feb 1, 2024 11:20AM

This issue was migrated from

crbug.com/chromium/582051?no_tracker_redirect=1

[Monorail components added to Component Tags custom field.]

is...@google.com <is...@google.com> #9Feb 1, 2024 11:20AM

This issue was migrated from

crbug.com/chromium/1475321?no_tracker_redirect=1

[Monorail blocking:

crbug.com/chromium/1309178,

crbug.com/chromium/1502669]
[Monorail components added to Component Tags custom field.]

xi...@chromium.org <xi...@chromium.org> #10Feb 5, 2024 03:42AM

Status: New

I'm no longer on the Chrome team and will have limited (but still some) time working on Chromium. Hence I'm putting all of my bugs back to the triage queue for someone to pick up.

fu...@google.com <fu...@google.com> Feb 7, 2024 09:14AM

Accepted by fu...@google.com.

ap...@google.com <ap...@google.com> #11Feb 7, 2024 10:01AM

Project: chromium/src
Branch: main

commit ed8169cbb00c3d73ba0f9b60da641e55d4d062f2
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Feb 07 09:58:44 2024

Moved position-try-order into wpt/ from wpt_internal/

Now part of the spec draft

Bug: 40279608
Change-Id: I35546256c8460bfa46d1b9b7607e008d069cbd6d
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5272498
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257259}

M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-order-computed.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-order-parsing.html

https://chromium-review.googlesource.com/5272498

ap...@google.com <ap...@google.com> #12Feb 8, 2024 10:09AM

Project: chromium/src
Branch: main

commit a85e3489d9a0d4abf8745ff132c6ca65aaf57bca
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Feb 08 10:08:36 2024

[css-anchor-position] Parsing and computing position-try-options

Part of the new auto-fallback proposal.

Bug: 40279608
Change-Id: If43e8af13a805cbd1b60cd8f44272ac431e4606c
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5272497
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257845}

M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/css_value_keywords.json5
M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/style/build.gni
A third_party/blink/renderer/core/style/position_try_options.cc
A third_party/blink/renderer/core/style/position_try_options.h
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-computed.html
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-parsing.html
M third_party/blink/web_tests/external/wpt/css/css-highlight-api/highlight-pseudo-computed-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
M tools/metrics/histograms/enums.xml

https://chromium-review.googlesource.com/5272497

fu...@google.com <fu...@google.com> Feb 8, 2024 10:46AM

Assigned to fu...@chromium.org.

fu...@chromium.org <fu...@chromium.org> Feb 8, 2024 10:46AM

Accepted by fu...@chromium.org.

ap...@google.com <ap...@google.com> #13Feb 12, 2024 12:16PM

Project: chromium/src
Branch: main

commit 18364bde4b3c7853fbd1e4a5c5cd016c93038f88
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Mon Feb 12 12:15:25 2024

[anchor] Remove anchor(auto), anchor(auto-same)

These no longer exist in the spec, and the new approach requires
a totally different solution.

Bug: 40279608
Change-Id: Ic852f4c1798123fe484f1e25bd42a12edaa41581
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5274757
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1259107}

M third_party/blink/renderer/core/css/calculation_expression_anchor_query_node.h
M third_party/blink/renderer/core/css/css_anchor_query_enums.h
M third_party/blink/renderer/core/css/css_math_expression_node.cc
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_value_keywords.json5
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/html/resources/html.css
M third_party/blink/renderer/core/html/resources/selectlist.css
M third_party/blink/renderer/core/layout/anchor_query.cc
M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
M third_party/blink/renderer/core/style/computed_style.h
M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
M third_party/blink/renderer/platform/geometry/calculation_expression_node.cc
M third_party/blink/renderer/platform/geometry/calculation_expression_node.h
M third_party/blink/renderer/platform/geometry/calculation_value.cc
M third_party/blink/renderer/platform/geometry/calculation_value.h
M third_party/blink/renderer/platform/geometry/length.cc
M third_party/blink/renderer/platform/geometry/length.h
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-position-auto-001.html
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-position-auto-002.html
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-position-auto-003-expected.txt
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-position-auto-003.html
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-position-auto-004.html
M third_party/blink/web_tests/external/wpt/html/dom/elements/global-attributes/the-anchor-attribute-003.tentative.html
M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/resources/stylable-select-styles.css
D third_party/blink/web_tests/wpt_internal/css/css-anchor-position/anchor-auto-cascade.html

https://chromium-review.googlesource.com/5274757

ap...@google.com <ap...@google.com> #14Feb 16, 2024 03:00PM

Project: chromium/src
Branch: main

commit c7267ef302fe2967efabf24d8456bb83ebd7cee5
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Feb 16 14:59:31 2024

[css-anchor-position] position-try shorthand parsing and computed

Bug: 40279608
Change-Id: I9af1dd56cba24a271da30fc01d573820d9e642c5
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5290844
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261631}

M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
M third_party/blink/renderer/core/css/properties/computed_style_utils.h
M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
M third_party/blink/renderer/core/css/style_property_serializer.cc
M third_party/blink/renderer/core/css/style_property_serializer.h
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-parsing.html
M third_party/blink/web_tests/external/wpt/css/cssom/cssom-getPropertyValue-common-checks-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
M tools/metrics/histograms/enums.xml

https://chromium-review.googlesource.com/5290844

ap...@google.com <ap...@google.com> #15Feb 16, 2024 03:00PM

https://chromium-review.googlesource.com/5290844

ap...@google.com <ap...@google.com> #16Feb 27, 2024 11:26PM

Project: chromium/src
Branch: main

commit 678486d38c9a83ce154df0bb407db5ce524dfb5b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Feb 27 23:23:30 2024

[css-anchor-position] Allow both flip and dashed-ident for option

The spec previously allowed either a named @position-try rule or a
tactic. Spec changed to allow flipping together with @position-try for a
single option.

Bug: 40279608
Change-Id: Ib30d6ba24d2ed3c8a7ae0d76f35709ce1ee2474b
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5324010
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1266146}

M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/style/position_try_options.h
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-computed.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-parsing.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-parsing.html

https://chromium-review.googlesource.com/5324010

ap...@google.com <ap...@google.com> #17Mar 4, 2024 12:49PM

Project: chromium/src
Branch: main

commit 195be11b6b2f714bb9a38c5d749b78aa94135ac6
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Mar 04 12:48:32 2024

[css-anchor-position] Missing computed style diff for position-try-*

Needs to invalidate layout for changes to style for anchor fallbacks.

Bug: 40279608
Change-Id: I9ebddcfa2f467b8f2f642a69391e19864dbd9dd5
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5332060
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267788}

M third_party/blink/renderer/core/style/computed_style_diff_functions.json5

https://chromium-review.googlesource.com/5332060

ap...@google.com <ap...@google.com> #18Mar 4, 2024 02:17PM

Project: chromium/src
Branch: main

commit 2ecef7ea90e49a2915f85002889dd1e0f8a863b1
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Mar 04 14:16:12 2024

[css-anchor-position] Parser support for @position-try rules

Adding parsing support for @position-try without removing support for
@position-fallback. @position-fallback rule are still being applied for
now.

Bug: 40279608
Change-Id: If81a0707287ee317fa4f8080afc459c157fad4e0
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5331723
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267819}

M third_party/blink/renderer/bindings/generated_in_core.gni
M third_party/blink/renderer/bindings/idl_in_core.gni
M third_party/blink/renderer/core/css/build.gni
A third_party/blink/renderer/core/css/css_position_try_rule.cc
A third_party/blink/renderer/core/css/css_position_try_rule.h
A third_party/blink/renderer/core/css/css_position_try_rule.idl
M third_party/blink/renderer/core/css/css_rule.h
M third_party/blink/renderer/core/css/parser/at_rule_descriptor_parser.cc
M third_party/blink/renderer/core/css/parser/css_at_rule_id.cc
M third_party/blink/renderer/core/css/parser/css_at_rule_id.h
M third_party/blink/renderer/core/css/parser/css_parser_impl.cc
M third_party/blink/renderer/core/css/parser/css_parser_impl.h
M third_party/blink/renderer/core/css/parser/css_property_parser.cc
M third_party/blink/renderer/core/css/style_rule.cc
M third_party/blink/renderer/core/css/style_rule.h
M third_party/blink/renderer/core/css/style_sheet_contents.cc
M third_party/blink/renderer/core/frame/frame_serializer.cc
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-parse.html
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/idlharness-expected.txt
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

https://chromium-review.googlesource.com/5331723

ap...@google.com <ap...@google.com> #19Mar 4, 2024 04:25PM

Project: chromium/src
Branch: main

commit db0d351a3ccf3bce3d82c0c2df66672a27f00138
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Mar 04 16:25:03 2024

[css-anchor-position] Rename valid_for for @position-try

Bug: 40279608
Change-Id: I17221df639f3feefa18829674a4013709107620c
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5331783
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267883}

M third_party/blink/renderer/build/scripts/core/css/properties/templates/css_properties.h.tmpl
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/element_rule_collector.cc
M third_party/blink/renderer/core/css/parser/css_property_parser.cc
M third_party/blink/renderer/core/css/properties/css_property.h
M third_party/blink/renderer/core/css/resolver/cascade_expansion.cc
M third_party/blink/renderer/core/css/resolver/cascade_expansion_test.cc
M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/css/rule_set.h

https://chromium-review.googlesource.com/5331783

ap...@google.com <ap...@google.com> #20Mar 4, 2024 06:30PM

Project: chromium/src
Branch: main

commit 1dbe79b3c05e32053210777180e60797a5771def
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Mar 04 18:28:36 2024

[css-anchor-position] Add @position-try rules to RuleSet

And collect them into the ScopedStyleResolver.

Bug: 40279608
Change-Id: I240ecc6daf0cf2ec9929151d54464d7bae6e3325
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5331734
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267955}

M third_party/blink/renderer/core/css/resolver/scoped_style_resolver.cc
M third_party/blink/renderer/core/css/resolver/scoped_style_resolver.h
M third_party/blink/renderer/core/css/rule_set.cc
M third_party/blink/renderer/core/css/rule_set.h

https://chromium-review.googlesource.com/5331734

ap...@google.com <ap...@google.com> #21Mar 4, 2024 07:41PM

Project: chromium/src
Branch: main

commit 31db90fa90023d1426e8065bce47bb5ed2be6638
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Mar 04 19:37:41 2024

[css-anchor-position] Add @position-try resolving to StyleResolver

@position-fallback is still the applied fallback styles, so there is no
behavioral change.

Some additional renaming of members and methods and invalidation
preparing for @position-try.

Bug: 40279608
Change-Id: I351b8242add53382a9130e2b4ea391c46ee48337
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5331621
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1268006}

M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/css/resolver/style_resolver.h
M third_party/blink/renderer/core/css/style_engine.cc
M third_party/blink/renderer/core/css/style_engine.h
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/dom/element.cc

https://chromium-review.googlesource.com/5331621

ap...@google.com <ap...@google.com> #22Mar 4, 2024 10:04PM

Project: chromium/src
Branch: main

commit 1b7e4fb07d1c327bbc98084a063c96018f4f8dac
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Mar 04 22:01:57 2024

[css-anchor-position] Add position-try-options for selectlist

Add @position-try and position-try-options alternatives in UA
stylesheets for selectlist and datalist. In preparation for switching
from position-fallback to position-try-options.

Also additional fixing of comments and names as part of the transition.

Bug: 40279608
Change-Id: I3cf1e65ead605ddc881be375b4cf1d9d23ed407a
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5331624
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1268079}

M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/out_of_flow_data.h
M third_party/blink/renderer/core/css/parser/css_property_parser.cc
M third_party/blink/renderer/core/css/resolver/style_cascade.h
M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/css/style_engine.cc
M third_party/blink/renderer/core/css/style_engine.h
M third_party/blink/renderer/core/css/style_recalc_context.h
M third_party/blink/renderer/core/html/resources/html.css
M third_party/blink/renderer/core/html/resources/selectlist.css
M third_party/blink/renderer/core/layout/layout_object.cc
M third_party/blink/renderer/core/layout/layout_object.h
M third_party/blink/renderer/platform/runtime_enabled_features.json5

https://chromium-review.googlesource.com/5331624

ap...@google.com <ap...@google.com> #23Mar 8, 2024 08:55AM

Project: chromium/src
Branch: main

commit 90514f937592932c80b00249f498e5f19116c082
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Fri Mar 08 08:53:20 2024

[anchor] Use designated initializers to test CascadePriority

The current flat list of arguments makes hard to understand what
they mean, e.g. "author, true, 0, false, false, 0, 0". It also
makes it cumbersome to make changes to CascadePriority, because
there are so many call sites (of the constructor) that require
adjustment.

We can use designated initializers in order to automatically get
a reasonable default for all these call sites whenever we add
something new.

There is no behavior change.

Bug: 40279608
Change-Id: I9afc55b8bc8ccb961b6c0aea59e61e0ad7e16f00
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5349364
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270079}

M third_party/blink/renderer/core/css/resolver/cascade_priority_test.cc

https://chromium-review.googlesource.com/5349364

ap...@google.com <ap...@google.com> #24Mar 8, 2024 10:43AM

Project: chromium/src
Branch: main

commit d99de87be83c397eb9a70f3324aae389633732e6
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Fri Mar 08 10:41:57 2024

[anchor] Rename CascadePriority::is_fallback_style => is_try_style

The old name was based on the @position-fallback rule,
which has now been replaced by @position-try.

There is no behavior change.

Bug: 40279608
Change-Id: Ib4e628c4704d27bd8bfc6d4a2a66c33cbec815da
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5347624
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270110}

M third_party/blink/renderer/core/css/element_rule_collector.cc
M third_party/blink/renderer/core/css/out_of_flow_data.h
M third_party/blink/renderer/core/css/resolver/cascade_expansion-inl.h
M third_party/blink/renderer/core/css/resolver/cascade_priority.h
M third_party/blink/renderer/core/css/resolver/cascade_priority_test.cc
M third_party/blink/renderer/core/css/resolver/match_result.cc
M third_party/blink/renderer/core/css/resolver/match_result.h
M third_party/blink/renderer/core/css/resolver/matched_properties_cache.cc
M third_party/blink/renderer/core/css/resolver/style_cascade.cc
M third_party/blink/renderer/core/css/resolver/style_cascade_test.cc

https://chromium-review.googlesource.com/5347624

ap...@google.com <ap...@google.com> #25Mar 8, 2024 02:57PM

Project: chromium/src
Branch: main

commit 1b3de913bc8ab96c0f8d5137ecffccda9bf0ccd4
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Fri Mar 08 14:55:41 2024

[anchor] Add CSSFlipRevertValue

This value behaves like CSSRevertLayerValue, except it reverts to the
value of a different property, given by the property parameter,
instead of reverting to a value for the same property like
revert-layer does. This "cross-property" revert-layer behavior
is useful for implementing "try tactics" [1] from
CSS Anchor Positioning.

CSSFlipRevertValue is entirely for internal use. There is no web-facing
change.

[1]

https://drafts.csswg.org/css-anchor-position-1/#typedef-position-try-options-try-tactic

Bug: 40279608
Change-Id: Ibd037448eb88d571501ccb125d11b09e45f64941
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5349521
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270180}

M third_party/blink/renderer/core/css/build.gni
A third_party/blink/renderer/core/css/css_flip_revert_value.cc
A third_party/blink/renderer/core/css/css_flip_revert_value.h
A third_party/blink/renderer/core/css/css_flip_revert_value_test.cc
M third_party/blink/renderer/core/css/css_revert_value_test.cc
M third_party/blink/renderer/core/css/css_value.cc
M third_party/blink/renderer/core/css/css_value.h
M third_party/blink/renderer/core/css/resolver/style_cascade.cc
M third_party/blink/renderer/core/css/resolver/style_cascade.h
M third_party/blink/renderer/core/css/resolver/style_cascade_test.cc

https://chromium-review.googlesource.com/5349521

ap...@google.com <ap...@google.com> #26Mar 8, 2024 03:11PM

Project: chromium/src
Branch: main

commit 7a7f1e1f6ee5a2038ea4be3dbafbbd826c11fc8b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Mar 08 15:08:59 2024

[css-anchor-position] Support -internal-* position-try-options

Used for UA styles for selectlist

Bug: 40279608
Change-Id: Ib58a8dd0a521d1e87b4f40825aad5476f118c9c1
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5352256
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270186}

M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
M third_party/blink/renderer/core/css/properties/css_parsing_utils_test.cc

https://chromium-review.googlesource.com/5352256

ap...@google.com <ap...@google.com> #27Mar 8, 2024 04:32PM

Project: chromium/src
Branch: main

commit 345453d8f10a817299af60a46f00392ef11eb656
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Fri Mar 08 16:29:44 2024

[anchor] Add a new try-tactics (internal) layer to CascadePriority

The try-tactics layer is a special internal layer which is intended
to only hold CSSRevertToValues. These revert-to values will revert
to the layer below (cross-property), which will useful for implementing
the try-tactics in CSS Anchor Positioning (see comment near
CSSRevertToValue).

Bug: 40279608
Change-Id: Idcb729ed43c0a23be53995d7874cc11bf06606ca
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5349486
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270225}

M third_party/blink/renderer/core/css/resolver/cascade_expansion-inl.h
M third_party/blink/renderer/core/css/resolver/cascade_map_test.cc
M third_party/blink/renderer/core/css/resolver/cascade_priority.h
M third_party/blink/renderer/core/css/resolver/cascade_priority_test.cc
M third_party/blink/renderer/core/css/resolver/match_result.cc
M third_party/blink/renderer/core/css/resolver/match_result.h
M third_party/blink/renderer/core/css/resolver/style_cascade.cc
M third_party/blink/renderer/core/css/resolver/style_cascade_test.cc

https://chromium-review.googlesource.com/5349486

ap...@google.com <ap...@google.com> #28Mar 8, 2024 06:07PM

Project: chromium/src
Branch: main

commit fe15af8b4c4e75d44660277c6cef6b8e018cd7d7
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Fri Mar 08 18:04:54 2024

[anchor] Add try-tactics set to the cascade

Similarly to what we do for the regular try set, this CL adds
a CSSPropertyValueSet to OutOfFlowData (the try-tactics set),
which is read during rule collection, and added to the match result
with is_try_tactics_style=true.

For now this is only used by tests. In the future,
StyleEngine::UpdateStyleForOutOfFlow will be responsible
for managing this set (which will ultimately come from out-of-flow
layout).

Bug: 40279608
Change-Id: I8a199c7a311941bcaab5091f374504edc68dfe40
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5349527
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270286}

M third_party/blink/renderer/core/css/element_rule_collector.cc
M third_party/blink/renderer/core/css/element_rule_collector.h
M third_party/blink/renderer/core/css/out_of_flow_data.cc
M third_party/blink/renderer/core/css/out_of_flow_data.h
M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/css/resolver/style_resolver_test.cc

https://chromium-review.googlesource.com/5349527

ap...@google.com <ap...@google.com> #29Mar 8, 2024 08:49PM

Project: chromium/src
Branch: main

commit 60691ac5a6adcacd09c7bf5e685c652607b4e533
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Mar 08 20:46:39 2024

[css-anchor-position] Apply position-try-options, not position-fallback

For @position-try/position-try-options, the first attempt is without any
@position-try styles applied which means we have to adjust a lot of
tests. Both by making sure the base styles overflow its containing block
to force the first fallback to be used, but also reset inset properties
in @position-try blocks where the inset properties in the base style
should not be leaked to the fallback attempts.

ActivateStyleForChosenOption() still uses the old fallback behavior if
none of the options fit. That will be fixed in a different CL. Also,
removing @position-fallback/position-fallback will be done in follow-up
CLs.

Had to correct UA styles for selectlist.

Bug: 40279608
Change-Id: I8efe299ae3a6230cdb8d7ec502a090dfc11b45a8
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5352367
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270370}

M third_party/blink/renderer/core/css/parser/css_property_parser.cc
M third_party/blink/renderer/core/css/resolver/style_resolver_test.cc
M third_party/blink/renderer/core/css/style_engine_test.cc
M third_party/blink/renderer/core/dom/element.cc
M third_party/blink/renderer/core/html/resources/html.css
M third_party/blink/renderer/core/html/resources/selectlist.css
M third_party/blink/renderer/core/layout/layout_object.cc
M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
M third_party/blink/renderer/core/style/computed_style.cc
M third_party/blink/renderer/core/style/computed_style.h
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-default-001.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-default-002.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-getComputedStyle-003.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-chained-fallback.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-001.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-002.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-003.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-004.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-005.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-006.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-007.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-008.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-009.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-010.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-011.html
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-fallback-position-parse.html
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-fallback-cssom.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-allowed-declarations.html
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-cssom.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-invalidation-shadow-dom.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-invalidation.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/chrome-1512373-2-crash.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-bounds-001.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-bounds-002.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-bounds-003.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-bounds-004.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-bounds-005.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-bounds-006.html
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-tree-scoped.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-001.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-002.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-003.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-004.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-cascade-layer-reorder.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-container-query.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-custom-property.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-dynamic.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-grid-001.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-pseudo-element.html
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-tree-scoped.html
M third_party/blink/web_tests/wpt_internal/css/css-anchor-position/try-cascade.html
M third_party/blink/web_tests/wpt_internal/css/css-anchor-position/try-initial-transition.html

https://chromium-review.googlesource.com/5352367

ap...@google.com <ap...@google.com> #30Mar 12, 2024 10:51AM

Project: chromium/src
Branch: main

commit a08e405765be4572648c7872e6b20f264a8fd8ac
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Mar 12 10:50:08 2024

[css-anchor-position] Fall back to no options applied

@position-try should fall back to the style with no options applied if
all options were overflowing the containing block.

Bug: 40279608
Change-Id: I745aa8da05df3a87696c223edeffdaf0df0ff94c
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5359207
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271462}

M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-chained-fallback.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-invalidation-shadow-dom.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-001.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-cascade-layer-reorder.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-tree-scoped.html
M third_party/blink/web_tests/wpt_internal/css/css-anchor-position/try-cascade.html
M third_party/blink/web_tests/wpt_internal/css/css-anchor-position/try-initial-transition.html

https://chromium-review.googlesource.com/5359207

ap...@google.com <ap...@google.com> #31Mar 12, 2024 12:36PM

Project: chromium/src
Branch: main

commit 482d8d4c49ec47c5d0b3c9c432ce6f6ae93f149b
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue Mar 12 12:35:20 2024

[anchor] Order-preserving <try-tactic>

The order of the "flips" within a <try-tactic> matters to the final
result, hence we have to preserve it.

- Use the regular pattern for converting between CSSValueID
and ComputedStyle-enum (css_value_id_mappings.h).
- Remove unused ComputedStyleUtils::ValueForPositionTryOptions.

Bug: 40279608
Change-Id: Iae70edc667222acf5854602334bc7973b1f8136b
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5361839
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271493}

M third_party/blink/renderer/core/css/css_value_id_mappings.h
M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/style/computed_style_constants.h
M third_party/blink/renderer/core/style/position_try_options.cc
M third_party/blink/renderer/core/style/position_try_options.h
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-computed.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-parsing.html
M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-parsing.html

https://chromium-review.googlesource.com/5361839

ap...@google.com <ap...@google.com> #32Mar 13, 2024 12:44PM

Project: chromium/src
Branch: main

commit 0beee350d814a0c310a85d2982645878a77c1e45
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Wed Mar 13 12:43:55 2024

[anchor] Generate flips using the try-tactics layer

Previous CLs (CL:5349527 and preceding) established a way for
an internal CSSPropertyValueSet (containing CSSFlipRevertValues)
to be added at the "try tactics layer" in the cascade.
This made it possible to carry out the various "flips" required
by CSS Anchor Positioning, even with interleaving anchor()
implemented (

crbug.com/41483417).

This CL uses the value specified in the position-try-options
property to generate those value-flipping CSSPropertyValueSets,
and adds them to the cascade.

For now, the flips only apply to insets and sizing properties.
Additionally, values are not yet rewritten during the flip
(e.g. anchor(left) to anchor(right), etc). This behavior will
be added separately.

Bug: 40279608
Change-Id: Iab85e96e343df1f4527a51e60e10154b4c938ee1
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5366066
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272096}

M third_party/blink/renderer/core/css/anchor_results.cc
M third_party/blink/renderer/core/css/build.gni
M third_party/blink/renderer/core/css/resolver/style_cascade.cc
M third_party/blink/renderer/core/css/resolver/style_resolver_test.cc
M third_party/blink/renderer/core/css/style_engine.cc
M third_party/blink/renderer/core/css/style_engine.h
A third_party/blink/renderer/core/css/try_value_flips.cc
A third_party/blink/renderer/core/css/try_value_flips.h
A third_party/blink/renderer/core/css/try_value_flips_test.cc
M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
M third_party/blink/renderer/core/style/position_try_options.h
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-base.html
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-basic.html
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-sizing.html

https://chromium-review.googlesource.com/5366066

ap...@google.com <ap...@google.com> #33Mar 14, 2024 11:46PM

Project: chromium/src
Branch: main

commit 8f1eaf3344c2549f588f4e43721693e813adf917
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Mar 14 23:43:11 2024

[css-anchor-position] Add @position-try rules to devtools protocol

Keep the @position-fallback/try rules, but deprecate them from the
protocol.

Bug: 40279608
Change-Id: I21396642efde5397b2eb9b003332911226c1366d
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5369798
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273131}

M third_party/blink/public/devtools_protocol/browser_protocol.pdl
M third_party/blink/renderer/core/css/css_property_source_data.h
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.h
M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.h
A third_party/blink/web_tests/inspector-protocol/css/css-get-position-try-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/css-get-position-try.js
A third_party/blink/web_tests/inspector-protocol/css/css-set-position-try-rule-style-text-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/css-set-position-try-rule-style-text.js
A third_party/blink/web_tests/inspector-protocol/css/resources/set-position-try-rule-style-text.css
M third_party/blink/web_tests/inspector-protocol/resources/css-helper.js

https://chromium-review.googlesource.com/5369798

ap...@google.com <ap...@google.com> #34Mar 15, 2024 08:54AM

Project: chromium/src
Branch: main

commit be8b7352654428043071d195e793532e24a83904
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Mar 15 08:51:25 2024

[css-anchor-position] Stop passing @position-fallback rules

As part of fully removing support for @position-fallback, don't pass any
@position-fallback rules over the devtools protocol. The protocol is not
modified, but the list of rules is never passed. This removes
dependencies on the @position-fallback code in css/ to make it possible
to remove the css/ part of the code.

Bug: 40279608
Change-Id: I03bdc44f8e7fce6c10878316ab7f55fd90f02214
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5369919
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273286}

M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.h
M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
D third_party/blink/web_tests/inspector-protocol/css/css-get-position-fallbacks.js
D third_party/blink/web_tests/inspector-protocol/css/css-set-try-rule-style-text.js
M third_party/blink/web_tests/virtual/view-transition-mpa-serialization/inspector-protocol/css/css-get-styles-for-view-transition-expected.txt
M third_party/blink/web_tests/virtual/view-transition-wide-gamut/inspector-protocol/css/css-get-styles-for-view-transition-expected.txt
M third_party/blink/web_tests/virtual/view-transition/inspector-protocol/css/css-get-styles-for-view-transition-expected.txt

https://chromium-review.googlesource.com/5369919

ap...@google.com <ap...@google.com> #35Mar 15, 2024 09:28AM

Project: chromium/src
Branch: main

commit 10e02f411006867126a3ecb2d77e414c36ed9b18
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Mar 15 09:27:30 2024

[css-anchor-position] Limit position options list to five

Limits the amount of excess layout work required for trying options.

Five is the lower cap for position options allowed by the spec.

Bug: 40279608
Change-Id: Iefdf2d97fbf6fcbcc0f1e53ead545e1c975d473a
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5372723
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273299}

M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-options-limit.html

https://chromium-review.googlesource.com/5372723

ap...@google.com <ap...@google.com> #36Mar 15, 2024 10:35AM

Project: chromium/src
Branch: main

commit c2d7448a91710d138734e4309ceae122bffdb27b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Mar 15 10:34:27 2024

[css-anchor-position] Remove support for position-fallback property

position-fallback is no longer in the spec, has no effect in application
of position fallback, and position-try-options has replaced it.

Bug: 40279608
Change-Id: I21f6a3e51623e0580608ccf0891b42d73dcbfd3e
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5371763
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273323}

M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/css/resolver/style_resolver.h
M third_party/blink/renderer/core/css/style_engine.cc
M third_party/blink/renderer/core/css/style_engine.h
M third_party/blink/renderer/core/dom/element.cc
M third_party/blink/renderer/core/dom/element.h
M third_party/blink/renderer/core/layout/layout_object.cc
M third_party/blink/renderer/core/style/computed_style.cc
M third_party/blink/renderer/core/style/computed_style.h
M third_party/blink/renderer/core/style/computed_style_diff_functions.json5
D third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-fallback-basics.html
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt

https://chromium-review.googlesource.com/5371763

ap...@google.com <ap...@google.com> #37Mar 15, 2024 12:50PM

Project: chromium/src
Branch: main

commit e65288ffc8071ce16ae9039ab81fbf3777646ba5
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Mar 15 12:49:29 2024

[css-anchor-position] Remove @position-fallback

The rule was parsed but never applied. Remove support completely.

Bug: 40279608
Change-Id: I78e94be091ef227b978d7953b5740e8e508fa9d1
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5372046
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273348}

M third_party/blink/renderer/bindings/generated_in_core.gni
M third_party/blink/renderer/bindings/idl_in_core.gni
M third_party/blink/renderer/core/css/build.gni
M third_party/blink/renderer/core/css/css_grouping_rule.cc
D third_party/blink/renderer/core/css/css_position_fallback_rule.cc
D third_party/blink/renderer/core/css/css_position_fallback_rule.h
D third_party/blink/renderer/core/css/css_position_fallback_rule.idl
M third_party/blink/renderer/core/css/css_property_source_data.h
M third_party/blink/renderer/core/css/css_rule.h
D third_party/blink/renderer/core/css/css_try_rule.cc
D third_party/blink/renderer/core/css/css_try_rule.h
D third_party/blink/renderer/core/css/css_try_rule.idl
M third_party/blink/renderer/core/css/parser/at_rule_descriptor_parser.cc
M third_party/blink/renderer/core/css/parser/css_at_rule_id.cc
M third_party/blink/renderer/core/css/parser/css_at_rule_id.h
M third_party/blink/renderer/core/css/parser/css_parser.cc
M third_party/blink/renderer/core/css/parser/css_parser.h
M third_party/blink/renderer/core/css/parser/css_parser_impl.cc
M third_party/blink/renderer/core/css/parser/css_parser_impl.h
M third_party/blink/renderer/core/css/parser/css_parser_impl_test.cc
M third_party/blink/renderer/core/css/parser/css_property_parser.cc
M third_party/blink/renderer/core/css/resolver/scoped_style_resolver.cc
M third_party/blink/renderer/core/css/resolver/scoped_style_resolver.h
M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/css/resolver/style_resolver.h
M third_party/blink/renderer/core/css/rule_set.cc
M third_party/blink/renderer/core/css/rule_set.h
M third_party/blink/renderer/core/css/style_engine.cc
M third_party/blink/renderer/core/css/style_rule.cc
M third_party/blink/renderer/core/css/style_rule.h
M third_party/blink/renderer/core/css/style_sheet_contents.cc
M third_party/blink/renderer/core/frame/frame_serializer.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.h
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

https://chromium-review.googlesource.com/5372046

ap...@google.com <ap...@google.com> #38Mar 18, 2024 02:44PM

Project: chromium/src
Branch: main

commit c7d7fe3aa08b41ed8a2c327ced6d7222c79e2141
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Mar 18 14:42:24 2024

[css-anchor-position] position-try-order behind a separate flag

position-try-order only have parsing support atm. Put it behind a
separate flag in case we won't ship it in the first release of anchor
positioning. Also put the position-try shorthand behind the same flag
since the shorthand only adds position-try-order to
position-try-options.

Bug: 40279608
Change-Id: I4848e7ceec8158fb45204ec8e86bb84c9f82e311
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5374119
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1274127}

M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/platform/runtime_enabled_features.json5

https://chromium-review.googlesource.com/5374119

ap...@google.com <ap...@google.com> #39Mar 19, 2024 01:15PM

Project: chromium/src
Branch: main

commit 4586f5831131c0cc15284c15f800ef9b9bd7fee4
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue Mar 19 13:14:22 2024

[anchor] Generalize flipping behavior as TryTacticTransform

Generating CSSPropertyValueSets with CSSFlipRevertValue (CL:5366066)
is not on its own enough to fully implement <try-tactic>: we also need
to transform the actual values for the properties we're flipping.

This CL prepares for that by representing the flipping behavior
as a TryTacticTransform. A TryTacticTransform represents the various
needed flips (in a fixed order), and can transform logical sides
according to these flips. See the class comment for more information.

Bug: 40279608
Change-Id: I33e7087ce38580b29efbbdcee880a151c3b10cf8
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5377734
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1274861}

M third_party/blink/renderer/core/css/build.gni
A third_party/blink/renderer/core/css/try_tactic_transform.h
A third_party/blink/renderer/core/css/try_tactic_transform_test.cc
M third_party/blink/renderer/core/css/try_value_flips.cc

https://chromium-review.googlesource.com/5377734

ap...@google.com <ap...@google.com> #40Mar 19, 2024 06:55PM

Project: chromium/src
Branch: main

commit c5a577742befa480548dcd7b1ddbb24f517d66df
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue Mar 19 18:51:38 2024

[anchor] Rename k[Logical,Physical]Axis to *Axes, add enum

Renaming *Axis to *Axes frees up the singular "axis" for the new
Logical/PhysicalAxis enum classes. These enums are more useful for
situations where it makes sense to deal with exactly one axis
at a time.

Bug: 40279608
Change-Id: I21c484c0f8ba2d8ce8bb89895faf6226bddc7fc7
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5376865
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275084}

M third_party/blink/renderer/core/css/container_query_evaluator.cc
M third_party/blink/renderer/core/css/container_query_evaluator_test.cc
M third_party/blink/renderer/core/css/container_query_test.cc
M third_party/blink/renderer/core/css/container_selector.cc
M third_party/blink/renderer/core/css/container_selector.h
M third_party/blink/renderer/core/css/css_to_length_conversion_data.cc
M third_party/blink/renderer/core/css/css_to_length_conversion_data.h
M third_party/blink/renderer/core/css/style_engine.cc
M third_party/blink/renderer/core/css/style_engine_test.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
M third_party/blink/renderer/core/layout/geometry/axis.h
M third_party/blink/renderer/core/layout/geometry/axis_test.cc
M third_party/blink/renderer/core/layout/layout_input_node.h
M third_party/blink/renderer/core/style/inset_area.cc

https://chromium-review.googlesource.com/5376865

ap...@google.com <ap...@google.com> #41Mar 19, 2024 07:41PM

Project: chromium/src
Branch: main

commit 47ede41ee5091579f8b1a07e9135831f6c792c3b
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue Mar 19 19:38:45 2024

[anchor] Implement transformation of anchor()/anchor-size()

This CL adds a new function to CSSMathFunctionValue which creates
a copy of the value (if needed), but with anchor()/anchor-size()
functions changed according to the specified TryTacticTransform.

This is needed in order to implement the various "flips" required
by CSS Anchor Positioning [1].

The function is only used from unit tests for now.

Bug: 40279608

[1]

https://drafts.csswg.org/css-anchor-position-1/#typedef-position-try-options-try-tactic

Change-Id: I67a99493bbeca028cca56bd4d680adfd545a9dde
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5377814
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275121}

M third_party/blink/renderer/core/css/css_math_expression_node.cc
M third_party/blink/renderer/core/css/css_math_expression_node.h
M third_party/blink/renderer/core/css/css_math_function_value.cc
M third_party/blink/renderer/core/css/css_math_function_value.h
M third_party/blink/renderer/core/css/try_value_flips.cc
M third_party/blink/renderer/core/css/try_value_flips.h
M third_party/blink/renderer/core/css/try_value_flips_test.cc

https://chromium-review.googlesource.com/5377814

ap...@google.com <ap...@google.com> #42Mar 19, 2024 08:37PM

Project: chromium/src
Branch: main

commit efece38c5251bbb33d408f06ec70763da4a2c9ef
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue Mar 19 20:34:23 2024

[anchor] Support flip-block/inline/start

This CL transports a TryTacticTransform in the CSSFlipRevertValue
within the flip-sets (see TryValueFlips::FlipSet), such that we can
transform the CSSValue appropriately during StyleCascade.

Bug: 40279608
Change-Id: I0480098e7718507e8940b1297bf1804cfd71ee6f
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5378703
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275154}

M third_party/blink/renderer/core/css/css_flip_revert_value.cc
M third_party/blink/renderer/core/css/css_flip_revert_value.h
M third_party/blink/renderer/core/css/css_flip_revert_value_test.cc
M third_party/blink/renderer/core/css/resolver/style_cascade.cc
M third_party/blink/renderer/core/css/resolver/style_cascade_test.cc
M third_party/blink/renderer/core/css/resolver/style_resolver_test.cc
M third_party/blink/renderer/core/css/try_value_flips.cc
M third_party/blink/renderer/core/css/try_value_flips_test.cc
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-anchor.html

https://chromium-review.googlesource.com/5378703

ap...@google.com <ap...@google.com> #43Mar 19, 2024 09:47PM

Project: chromium/src
Branch: main

commit f97479a0fa6c91467c2f3c8986fab6ecf8d2ecf1
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue Mar 19 21:45:54 2024

[anchor] Support try-tactic flips for margin properties

Bug: 40279608
Change-Id: I5abec573f4357c1b823a7e9effdade37205a80da
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5371769
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275217}

M third_party/blink/renderer/core/css/try_value_flips.cc
M third_party/blink/renderer/core/css/try_value_flips_test.cc
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-margin.html

https://chromium-review.googlesource.com/5371769

ap...@google.com <ap...@google.com> #44Mar 20, 2024 09:57AM

Project: chromium/src
Branch: main

commit af5b2a2992d949a51e263e6cecec57433ba6e6c2
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Wed Mar 20 09:55:11 2024

[anchor] Support try-tactic flips for anchor(<percentage>)

Bug: 40279608
Change-Id: I01cc03f8864424cadaa623734e644c1c2b5a742f
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5372481
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275456}

M third_party/blink/renderer/core/css/css_math_expression_node.cc
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-percentage.html

https://chromium-review.googlesource.com/5372481

ap...@google.com <ap...@google.com> #45Mar 21, 2024 01:21PM

Project: chromium/src
Branch: main

commit 3557f86ff1f35b03ff10e38f9bafe4e5256f008e
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Thu Mar 21 13:20:29 2024

[anchor] Support try-tactic flips for self-alignment properties

The self-alignment properties are a bit different from the other
properties that require adjustment.

For insets and sizes, a value transformation (e.g. anchor(right)
becoming anchor(left)) is always accompanied by a corresponding property
transformation (e.g. left becoming right), but for self-alignment
properties we need value transformation within the same property.
E.g. justify-self:start under flip-start becomes justify-self:end
(no change in property). Therefore these properties are always present
in the try-tactics layer.

Also, it's worth noting that justify-self accepts the 'left' and
'right' keywords, but align-self does not accept 'top'/'bottom'.
This means we can't just naively grab-and-flip the value of the other
property for flip-start: we need to convert left/right to logical
to avoid giving align-self an invalid value. Since the exact details
of what left/right should become in this case is non-obvious
(and not specified) [1], I've avoided this case in the WPT for now.

Bug: 40279608

[1]

https://github.com/w3c/csswg-drafts/issues/10049

Change-Id: I8fa675a0be3f3c50ca73b4b628583765e252b032
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5383077
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276166}

M third_party/blink/renderer/core/css/try_value_flips.cc
M third_party/blink/renderer/core/css/try_value_flips_test.cc
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-alignment.html

https://chromium-review.googlesource.com/5383077

ap...@google.com <ap...@google.com> #46Mar 21, 2024 07:25PM

Project: chromium/src
Branch: main

commit e8bfb4a6b970df9a55d946225c6a5df532fdf2d2
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Thu Mar 21 19:18:56 2024

[anchor] Support try-tactic flips for inset-area

Since inset-area is not yet fully supported within @position-try,
this CL tests the flipping behavior via computed value only.

Like the self-alignment properties, inset-area must always be present
in the try-tactics layer, because we need to transform the value
without switching the property itself.

Bug: 40279608
Change-Id: Ibd7bd786e256c2142590290e37e188806eadb7a3
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5383432
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1276424}

M third_party/blink/renderer/core/css/try_value_flips.cc
M third_party/blink/renderer/core/css/try_value_flips_test.cc
A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-inset-area.html

https://chromium-review.googlesource.com/5383432

fu...@chromium.org <fu...@chromium.org> Mar 27, 2024 08:45AM

Marked as fixed.

ap...@google.com <ap...@google.com> #47Apr 4, 2024 09:23AM

Project: chromium/src
Branch: main

commit f1e9a5bb474a552a522568f2571ed2b01fbbb42d
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Thu Apr 04 09:21:45 2024

[anchor] Cache flip sets on StyleEngine

Since there are only seven different transforms, and each transform
corresponds to a CSSPropertyValueSet which is independent of the style
being transformed, we can easily cache the seven sets on StyleEngine.

This avoids unnecessary style recalc when calling
UpdateStyleForOutOfFlow with the same try set and try tactics set
we already had on OutOfFlowData.

Bug: 40279608
Change-Id: I597124bdec9a2986ebd0ce62eeaadd3547fec3cf
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5416133
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282377}

M third_party/blink/renderer/core/css/style_engine.cc
M third_party/blink/renderer/core/css/style_engine.h
M third_party/blink/renderer/core/css/style_engine_test.cc
M third_party/blink/renderer/core/css/try_tactic_transform.h
M third_party/blink/renderer/core/css/try_tactic_transform_test.cc
M third_party/blink/renderer/core/css/try_value_flips.cc
M third_party/blink/renderer/core/css/try_value_flips.h

https://chromium-review.googlesource.com/5416133

ap...@google.com <ap...@google.com> #48Apr 4, 2024 10:14AM

Project: chromium/src
Branch: main

commit 3a6eeba70ed2263e2c69d227e30fcb63b6757b75
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Thu Apr 04 10:11:18 2024

[anchor] Update and document kMaxDeclarations

Bug: 40279608
Change-Id: I423cc6b39402f9b3ef689a8afa0c5f5a99a1795b
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5421788
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282387}

M third_party/blink/renderer/core/css/try_value_flips.cc

https://chromium-review.googlesource.com/5421788

ap...@google.com <ap...@google.com> #49Apr 4, 2024 12:52PM

Project: chromium/src
Branch: main

commit ef29cf6f7bdb019836e05fe1a84510d408db718b
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Thu Apr 04 12:51:11 2024

[anchor] Add WPT for <try-tactic> under different writing modes

Bug: 40279608
Change-Id: Ib2394f1b08f28fb5fbc1a60cc769067fe3516216
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5419977
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282437}

A third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-wm.html

https://chromium-review.googlesource.com/5419977

ap...@google.com <ap...@google.com> #50Sep 5, 2024 09:49PM

Project: chromium/src
Branch: main

commit b8d4478a94995413515883c25e2f4fe5e567cd22
Author: Mason Freed <masonf@chromium.org>
Date: Thu Sep 05 21:46:36 2024

Fix up position-try for customizable-<select>

The prior rules had several bugs, including mismatched names.
This cleans that up, plus uses `position-area` shorthands.
Note that I don't think we need four alternative positions
that all have scrollbars - one would seem to suffice.

Note that the new tests are disabled on Windows and Linux due to
an invalidation issue with the test harness (

crbug.com/364669904).
But all four work correctly on Mac.

Fixed: 362536387
Bug: 40279608,363205525,364340016,364669904
Change-Id: Ife4b52d1103bb5162eb1502cdba5f25a8a8cde7b
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5827727
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351699}

M third_party/blink/renderer/core/html/resources/stylable_select.css
M third_party/blink/web_tests/TestExpectations
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/resources/fallback-helper.js
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-bottom-left-ref.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-bottom-left.tentative.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-bottom-right-ref.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-bottom-right.tentative.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-top-left-ref.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-top-left.tentative.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-top-right-ref.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/stylable-select/select-appearance-fallback-top-right.tentative.html

https://chromium-review.googlesource.com/5827727

ma...@gmail.com <ma...@gmail.com> #51Sep 5, 2024 11:11PM

ok

في الجمعة، ٦ سبتمبر ٢٠٢٤ ١٢:٥٠ ص <buganizer-system@google.com> كتب:

- Show quoted text -