Fixed
Status Update
No update yet.
Comments
aw...@chromium.org
[Description Changed]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/149259c2932e66995c8b87d8a738e7ba064606b1
commit 149259c2932e66995c8b87d8a738e7ba064606b1
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed Sep 06 20:53:49 2023
[css-scroll-snap-2] Add SnapEvent Definition
snapChanged and snapChanging are new JavaScript events defined by
the css-scroll-snap-2 spec[1]. These events are explained here[2] and
will be have more details in the spec[1] when this change[3] is merged
into the working group's repo.
SnapEvent, added by this patch, defines the interface for these new
events.
Bug:1456339
[1]https://drafts.csswg.org/css-scroll-snap-2/#snapchanged-and-snapchanging
[2]https://github.com/argyleink/ScrollSnapExplainers/tree/main/
[3]https://github.com/w3c/csswg-drafts/pull/9056
Change-Id: Ic009ca9706de46128c7b0d68528c60a980067b2a
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/4599639
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1193240}
[modify]https://crrev.com/149259c2932e66995c8b87d8a738e7ba064606b1/third_party/blink/renderer/platform/runtime_enabled_features.json5
[add]https://crrev.com/149259c2932e66995c8b87d8a738e7ba064606b1/third_party/blink/renderer/core/scroll/snap_event.idl
[add]https://crrev.com/149259c2932e66995c8b87d8a738e7ba064606b1/third_party/blink/renderer/core/scroll/snap_event.h
[modify]https://crrev.com/149259c2932e66995c8b87d8a738e7ba064606b1/third_party/blink/renderer/core/scroll/build.gni
[add]https://crrev.com/149259c2932e66995c8b87d8a738e7ba064606b1/third_party/blink/renderer/core/scroll/snap_event.cc
[modify]https://crrev.com/149259c2932e66995c8b87d8a738e7ba064606b1/third_party/blink/renderer/bindings/idl_in_core.gni
[modify]https://crrev.com/149259c2932e66995c8b87d8a738e7ba064606b1/third_party/blink/renderer/bindings/generated_in_core.gni
commit 149259c2932e66995c8b87d8a738e7ba064606b1
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed Sep 06 20:53:49 2023
[css-scroll-snap-2] Add SnapEvent Definition
snapChanged and snapChanging are new JavaScript events defined by
the css-scroll-snap-2 spec[1]. These events are explained here[2] and
will be have more details in the spec[1] when this change[3] is merged
into the working group's repo.
SnapEvent, added by this patch, defines the interface for these new
events.
Bug:1456339
[1]
[2]
[3]
Change-Id: Ic009ca9706de46128c7b0d68528c60a980067b2a
Reviewed-on:
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1193240}
[modify]
[add]
[add]
[modify]
[add]
[modify]
[modify]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/ce4bc9571462aa298d79b591df9d997323cf5157
commit ce4bc9571462aa298d79b591df9d997323cf5157
Author: David Awogbemila <awogbemila@chromium.org>
Date: Fri Sep 08 16:33:07 2023
[css-scroll-snap-2] Add snapChanged event
snapChanged is a new JavaScript event defined by
the css-scroll-snap-2 spec[1]. This event is explained here[2] and
will be more fleshed out in the spec[1] when this PR[3] is merged.
Bug:1456339
[1]https://drafts.csswg.org/css-scroll-snap-2/#snapchanged-and-snapchanging
[2]https://github.com/argyleink/ScrollSnapExplainers/tree/main/
[3]https://github.com/w3c/csswg-drafts/pull/9056
Change-Id: I68015f6a96f5f0a835d5731fcc85441bfbf84368
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/4599849
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194164}
[modify]https://crrev.com/ce4bc9571462aa298d79b591df9d997323cf5157/third_party/blink/renderer/core/html/html_element.cc
[modify]https://crrev.com/ce4bc9571462aa298d79b591df9d997323cf5157/third_party/blink/renderer/core/dom/events/event_target.h
[modify]https://crrev.com/ce4bc9571462aa298d79b591df9d997323cf5157/third_party/blink/renderer/core/dom/global_event_handlers.idl
[modify]https://crrev.com/ce4bc9571462aa298d79b591df9d997323cf5157/third_party/blink/renderer/core/html/html_attribute_names.json5
[modify]https://crrev.com/ce4bc9571462aa298d79b591df9d997323cf5157/third_party/blink/renderer/core/events/event_type_names.json5
commit ce4bc9571462aa298d79b591df9d997323cf5157
Author: David Awogbemila <awogbemila@chromium.org>
Date: Fri Sep 08 16:33:07 2023
[css-scroll-snap-2] Add snapChanged event
snapChanged is a new JavaScript event defined by
the css-scroll-snap-2 spec[1]. This event is explained here[2] and
will be more fleshed out in the spec[1] when this PR[3] is merged.
Bug:1456339
[1]
[2]
[3]
Change-Id: I68015f6a96f5f0a835d5731fcc85441bfbf84368
Reviewed-on:
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194164}
[modify]
[modify]
[modify]
[modify]
[modify]
aw...@chromium.org
[Description Changed]
aw...@chromium.org
Re-purposing this bug to handle snapchanged alone. I will file a different bug to track snapchanging work.
Noting a few issues the spec should probably clarify/handle:
1. Should SnapEvent.snapTargets be per-axis?
If snapchanged events have only one (axis-agnostic) list of targets, developers may need to use logic in JavaScript to try to figure out whether a bi-snappable element (an element which may be snapped to on both axes, per its scroll-snap-align value) is snapped to on a particular axis. This scenario feels a little like one where the purpose of snapchanged is somewhat defeated, though I'm not sure how important a use case it will be.
2. Should snapchanged fire before or after scrollend?
For snap containers, both events may be triggered at the end of a scroll. Knowing what order these events fire in will make snapchanged more useful for developers. I think that snapchanged should fire before scrollend - we will need to update the scroll steps[1] referred to by the html event loop processing model[2] to spec this.
3. Should changes to scroll-snap-type trigger snapchanged?
4. Criteria for SnapEvent.snapTargets.
SnapEvent.snapTargets should include snap areas that can be considered snapped to at a given snap position.
It would be good for the spec to include explicit criteria for including snap areas in SnapEvent.snapTargets for cross-browser interoperability.
[1]https://drafts.csswg.org/cssom-view/#document-run-the-scroll-steps
[2]https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model#:~:text=run%20the%20scroll%20steps
Noting a few issues the spec should probably clarify/handle:
1. Should SnapEvent.snapTargets be per-axis?
If snapchanged events have only one (axis-agnostic) list of targets, developers may need to use logic in JavaScript to try to figure out whether a bi-snappable element (an element which may be snapped to on both axes, per its scroll-snap-align value) is snapped to on a particular axis. This scenario feels a little like one where the purpose of snapchanged is somewhat defeated, though I'm not sure how important a use case it will be.
2. Should snapchanged fire before or after scrollend?
For snap containers, both events may be triggered at the end of a scroll. Knowing what order these events fire in will make snapchanged more useful for developers. I think that snapchanged should fire before scrollend - we will need to update the scroll steps[1] referred to by the html event loop processing model[2] to spec this.
3. Should changes to scroll-snap-type trigger snapchanged?
4. Criteria for SnapEvent.snapTargets.
SnapEvent.snapTargets should include snap areas that can be considered snapped to at a given snap position.
It would be good for the spec to include explicit criteria for including snap areas in SnapEvent.snapTargets for cross-browser interoperability.
[1]
[2]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/621af24357053ee3227b672520101df693a7ae46
commit 621af24357053ee3227b672520101df693a7ae46
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Nov 02 22:37:01 2023
[css-scroll-snap-2] Implement snapchanged for programmatic scrolls
snapchanged[1] (explainer[2]) should fire when a scroller snaps to a
different element than it was previously snapped to.
This pull request[3] will copy the details from the explainer to the
spec.
Bug:1456339
[1]https://drafts.csswg.org/css-scroll-snap-2/#snapchanged-and-snapchanging
[2]https://github.com/argyleink/ScrollSnapExplainers/tree/main/
[3]https://github.com/w3c/csswg-drafts/pull/9056
Change-Id: I8e798920a2a1ffc19af9ea3f274a94db976cc87d
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/4621862
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1219164}
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/cc/input/scroll_snap_data.cc
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/dom/global_event_handlers.idl
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/frame/visual_viewport.h
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/cc/input/scroll_snap_data.h
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/scroll/scrollable_area.cc
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/dom/document.h
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-with-proximity-strictness.tentative.html
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/dom/document.cc
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/frame/root_frame_viewport.h
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-same-targets-after-layout-changed.html
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/scroll/scrollable_area.h
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/page/page_animator.cc
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-interrupted-scroll.tentative.html
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-after-layout-change.tentative.html
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-ensures-dom-order.html
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/resources/common.js
[add]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify]https://crrev.com/621af24357053ee3227b672520101df693a7ae46/third_party/blink/renderer/core/scroll/scroll_animator_test.cc
commit 621af24357053ee3227b672520101df693a7ae46
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Nov 02 22:37:01 2023
[css-scroll-snap-2] Implement snapchanged for programmatic scrolls
snapchanged[1] (explainer[2]) should fire when a scroller snaps to a
different element than it was previously snapped to.
This pull request[3] will copy the details from the explainer to the
spec.
Bug:1456339
[1]
[2]
[3]
Change-Id: I8e798920a2a1ffc19af9ea3f274a94db976cc87d
Reviewed-on:
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1219164}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
[modify]
[modify]
[add]
[modify]
[add]
[add]
[modify]
[add]
[add]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c25caff98675c352b6fd275b9a2f8b05e37d20f8
commit c25caff98675c352b6fd275b9a2f8b05e37d20f8
Author: David Awogbemila <awogbemila@chromium.org>
Date: Mon Nov 13 16:43:53 2023
Reland "[css-scroll-snap-2] Implement snapchanged for user scrolls"
This is a reland of commit 5fe9b8c1093df2e89604d785b5acfc8f7323c6c8
A leak detection builder[1] was failing, seemingly because the test
finished without waiting for a promise.
The "Bug:" association in the commit description is also corrected.
Original change's description:
commit c25caff98675c352b6fd275b9a2f8b05e37d20f8
Author: David Awogbemila <awogbemila@chromium.org>
Date: Mon Nov 13 16:43:53 2023
Reland "[css-scroll-snap-2] Implement snapchanged for user scrolls"
This is a reland of commit 5fe9b8c1093df2e89604d785b5acfc8f7323c6c8
A leak detection builder[1] was failing, seemingly because the test
finished without waiting for a promise.
The "Bug:" association in the commit description is also corrected.
Original change's description:
[1]
Bug: 1500972,1456339
Change-Id: I8c1dd52d5ae55a1eb756d95faf9990bd2de6e5e4
Reviewed-on:
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1223681}
[modify]
[modify]
[add]
[modify]
[modify]
[add]
[add]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/23f4079ea7cc56643c2558e47345095e4f711520
commit 23f4079ea7cc56643c2558e47345095e4f711520
Author: David Awogbemila <awogbemila@chromium.org>
Date: Tue Nov 14 16:09:28 2023
Pull common snap event wpt code together (part 1)
Much of the test code written for snapchanged can be reused for
snapchanging. This is the first patch in a 2-patch attempt to put the
common code in one place: css/css-scroll-snap-2/resources/common.js so
that the functions can simply be called with either "snapchanged" or
"snapchanging" when we are adding tests for snapchanging.
The attempt is separated into two parts so it's easier to see what changes are being made to the functions (part 1) vs code that's just being moved to a common location (part 2).
Bug: 1494892, 1456339
Change-Id: Ia93cf8edf73e321a5a45a20b93c25f288eaab945
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5026336
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224317}
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-with-proximity-strictness.tentative.html
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-after-layout-change.tentative.html
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/resources/common.js
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-ensures-dom-order.html
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/resources/user-scroll-common.js
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-same-targets-after-layout-changed.html
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html
[modify]https://crrev.com/23f4079ea7cc56643c2558e47345095e4f711520/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html
commit 23f4079ea7cc56643c2558e47345095e4f711520
Author: David Awogbemila <awogbemila@chromium.org>
Date: Tue Nov 14 16:09:28 2023
Pull common snap event wpt code together (part 1)
Much of the test code written for snapchanged can be reused for
snapchanging. This is the first patch in a 2-patch attempt to put the
common code in one place: css/css-scroll-snap-2/resources/common.js so
that the functions can simply be called with either "snapchanged" or
"snapchanging" when we are adding tests for snapchanging.
The attempt is separated into two parts so it's easier to see what changes are being made to the functions (part 1) vs code that's just being moved to a common location (part 2).
Bug: 1494892, 1456339
Change-Id: Ia93cf8edf73e321a5a45a20b93c25f288eaab945
Reviewed-on:
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224317}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/97dcdd86f154c931648e19444dca3593562228ff
commit 97dcdd86f154c931648e19444dca3593562228ff
Author: David Awogbemila <awogbemila@chromium.org>
Date: Tue Nov 14 18:14:44 2023
Pull common snap event wpt code together (part 2)
Much of the test code written for snapchanged can be reused for
snapchanging. This is the second patch in a 2-patch attempt to put the
common code in one place: css/css-scroll-snap-2/resources/common.js so
that the functions can simply be called with either "snapchanged" or
"snapchanging" when we are adding tests for snapchanging.
Bug: 1494892, 1456339
Change-Id: I26cefefbb6bb9b8d878c0fff8e2eb694539cc8b6
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5025938
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224398}
[rename]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/common.js
[rename]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/user-scroll-common.js
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-with-proximity-strictness.tentative.html
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-after-layout-change.tentative.html
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-ensures-dom-order.html
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-same-targets-after-layout-changed.html
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html
[modify]https://crrev.com/97dcdd86f154c931648e19444dca3593562228ff/third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html
commit 97dcdd86f154c931648e19444dca3593562228ff
Author: David Awogbemila <awogbemila@chromium.org>
Date: Tue Nov 14 18:14:44 2023
Pull common snap event wpt code together (part 2)
Much of the test code written for snapchanged can be reused for
snapchanging. This is the second patch in a 2-patch attempt to put the
common code in one place: css/css-scroll-snap-2/resources/common.js so
that the functions can simply be called with either "snapchanged" or
"snapchanging" when we are adding tests for snapchanging.
Bug: 1494892, 1456339
Change-Id: I26cefefbb6bb9b8d878c0fff8e2eb694539cc8b6
Reviewed-on:
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224398}
[rename]
[rename]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/e4278da3d51fa0a73c5f04271f0991d23dfb5a4f
commit e4278da3d51fa0a73c5f04271f0991d23dfb5a4f
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Dec 07 16:02:05 2023
Correct experiment condition.
The if statement is guarding a call to EnqueueSnapChanged, not
EnqueueSnapChanging so it should check that the SnapChanged experiment
is enabled.
Bug: 1494892, 1456339
Change-Id: I5ee0e0210e10506906d711e4fbdcde7ac9c72b1d
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5097363
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234515}
[modify]https://crrev.com/e4278da3d51fa0a73c5f04271f0991d23dfb5a4f/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
commit e4278da3d51fa0a73c5f04271f0991d23dfb5a4f
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Dec 07 16:02:05 2023
Correct experiment condition.
The if statement is guarding a call to EnqueueSnapChanged, not
EnqueueSnapChanging so it should check that the SnapChanged experiment
is enabled.
Bug: 1494892, 1456339
Change-Id: I5ee0e0210e10506906d711e4fbdcde7ac9c72b1d
Reviewed-on:
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234515}
[modify]
is...@google.com
This issue was migrated from crbug.com/chromium/1456339?no_tracker_redirect=1
[Monorail components added to Component Tags custom field.]
[Monorail components added to Component Tags custom field.]
ap...@google.com
Project: chromium/src
Branch: main
commit 7465ac8b4a79193187425a4d7b135d081e53e9c9
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed Apr 03 15:47:21 2024
[css-scroll-snap-2] Set snap events to experimental
Based on the guidelines[1], I think we can set the snap event features to "experimental" status.
[1]https://chromium.googlesource.com/chromium/src/third_party/+/HEAD/blink/renderer/platform/RuntimeEnabledFeatures.md#guidelines-for-setting-feature-status
Bug: 1494892,1456339
Change-Id: Ibb9864ecacfade2a3980f52ad02b85ad0cd4dfa1
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5415095
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1281878}
M third_party/blink/renderer/platform/runtime_enabled_features.json5
https://chromium-review.googlesource.com/5415095
Branch: main
commit 7465ac8b4a79193187425a4d7b135d081e53e9c9
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed Apr 03 15:47:21 2024
[css-scroll-snap-2] Set snap events to experimental
Based on the guidelines[1], I think we can set the snap event features to "experimental" status.
[1]
Bug: 1494892,1456339
Change-Id: Ibb9864ecacfade2a3980f52ad02b85ad0cd4dfa1
Reviewed-on:
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1281878}
M third_party/blink/renderer/platform/runtime_enabled_features.json5
ap...@google.com
Project: chromium/src
Branch: main
commit 07a219aa684acc3977c9043f39bd1fc88ce5f6df
Author: David Awogbemila <awogbemila@chromium.org>
Date: Fri Apr 05 16:03:45 2024
[css-scroll-snap-2] Add UseCounters for snap events.
Bug: 40286359, 40273052
Change-Id: I1710993e4e7f535f793f02ff964d4af0cecd1485
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5425711
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283175}
M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
M third_party/blink/renderer/core/dom/events/event_target.cc
M third_party/blink/renderer/core/dom/events/event_target_test.cc
M third_party/blink/renderer/core/events/event_util.cc
M third_party/blink/renderer/core/events/event_util.h
M tools/metrics/histograms/enums.xml
https://chromium-review.googlesource.com/5425711
Branch: main
commit 07a219aa684acc3977c9043f39bd1fc88ce5f6df
Author: David Awogbemila <awogbemila@chromium.org>
Date: Fri Apr 05 16:03:45 2024
[css-scroll-snap-2] Add UseCounters for snap events.
Bug: 40286359, 40273052
Change-Id: I1710993e4e7f535f793f02ff964d4af0cecd1485
Reviewed-on:
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283175}
M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
M third_party/blink/renderer/core/dom/events/event_target.cc
M third_party/blink/renderer/core/dom/events/event_target_test.cc
M third_party/blink/renderer/core/events/event_util.cc
M third_party/blink/renderer/core/events/event_util.h
M tools/metrics/histograms/enums.xml
ap...@google.com
Project: chromium/src
Branch: main
commit 810467d7d6f3c380197b8d36df4ce898baf36bd7
Author: David Awogbemila <awogbemila@chromium.org>
Date: Fri Apr 12 01:56:13 2024
[css-scroll-snap-2] Add onsnap* member test variants
In favor of a simpler way to test the onsnap* members which allows all
the combinations of
{addEventListener, onsnap*} x {snapchanged, snapchanging} x
{programmatic, user} tests to use the same code, this undoes some of
the changes fromcrrev.com/c/5418784 which added onsnap* member test
variants for snapchanging.
Bug: 40286359, 40273052
Change-Id: I823dcbb4d57ce3b3610cfe17fef221bfb6bf2bdb
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5439856
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1286248}
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/common.js
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/programmatic-scroll-common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/user-scroll-common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-user-scroll.tentative.html
https://chromium-review.googlesource.com/5439856
Branch: main
commit 810467d7d6f3c380197b8d36df4ce898baf36bd7
Author: David Awogbemila <awogbemila@chromium.org>
Date: Fri Apr 12 01:56:13 2024
[css-scroll-snap-2] Add onsnap* member test variants
In favor of a simpler way to test the onsnap* members which allows all
the combinations of
{addEventListener, onsnap*} x {snapchanged, snapchanging} x
{programmatic, user} tests to use the same code, this undoes some of
the changes from
variants for snapchanging.
Bug: 40286359, 40273052
Change-Id: I823dcbb4d57ce3b3610cfe17fef221bfb6bf2bdb
Reviewed-on:
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1286248}
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/common.js
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/programmatic-scroll-common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/user-scroll-common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanging/snapchanging-on-user-scroll.tentative.html
ap...@google.com
Project: chromium/src
Branch: main
commit 80220c17284dcea67a5aa6034416d48bc7896f66
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Apr 18 14:37:45 2024
[css-scroll-snap-2] Set snapTargets to owning element of pseudo-element areas
Currently, JavaScript cannot interact with pseudo-elements in the same
way that it can with regular elements. This is raised in a spec
issue[1] where the current proposal is to treat snap events involving
pseudo-elements the same way that pointer events treat pseudo-elements:
let the snapTarget be the owning element.
[1]https://github.com/w3c/csswg-drafts/issues/10175
Bug: 40273052,40286359
Change-Id: I9e2a99de94eada4e06bcdab753d45f4ae46a2e46
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5458351
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1289306}
M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
A third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snap-events-with-pseudo-target.tentative.html
https://chromium-review.googlesource.com/5458351
Branch: main
commit 80220c17284dcea67a5aa6034416d48bc7896f66
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Apr 18 14:37:45 2024
[css-scroll-snap-2] Set snapTargets to owning element of pseudo-element areas
Currently, JavaScript cannot interact with pseudo-elements in the same
way that it can with regular elements. This is raised in a spec
issue[1] where the current proposal is to treat snap events involving
pseudo-elements the same way that pointer events treat pseudo-elements:
let the snapTarget be the owning element.
[1]
Bug: 40273052,40286359
Change-Id: I9e2a99de94eada4e06bcdab753d45f4ae46a2e46
Reviewed-on:
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1289306}
M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
A third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snap-events-with-pseudo-target.tentative.html
ap...@google.com
Project: chromium/src
Branch: main
commit 78c8e7cf0c1502c58936d66b2b0928ac3d35d472
Author: David Awogbemila <awogbemila@chromium.org>
Date: Mon May 06 16:36:01 2024
Make snap events bubble when fired at the document.
The CSS working group came to a resolution[1] that snap events should
bubble when targeted at the document.
This aligns with the behavior of scroll and scrollend events.
[1]https://github.com/w3c/csswg-drafts/issues/10173
Bug: 40286359, 40273052
Change-Id: Ie977a39df04c5ee0bd7f62319119603a59ed7c22
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5513923
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1296898}
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/scroll/snap_event.cc
M third_party/blink/renderer/core/scroll/snap_event.h
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/common.js
A third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapevents-at-document-bubble-to-window.html
https://chromium-review.googlesource.com/5513923
Branch: main
commit 78c8e7cf0c1502c58936d66b2b0928ac3d35d472
Author: David Awogbemila <awogbemila@chromium.org>
Date: Mon May 06 16:36:01 2024
Make snap events bubble when fired at the document.
The CSS working group came to a resolution[1] that snap events should
bubble when targeted at the document.
This aligns with the behavior of scroll and scrollend events.
[1]
Bug: 40286359, 40273052
Change-Id: Ie977a39df04c5ee0bd7f62319119603a59ed7c22
Reviewed-on:
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1296898}
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/scroll/snap_event.cc
M third_party/blink/renderer/core/scroll/snap_event.h
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/common.js
A third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapevents-at-document-bubble-to-window.html
ap...@google.com
Project: chromium/src
Branch: main
commit 090dfd92b94d55c2a0ac9bd3d497e73f4d6b6b70
Author: David Awogbemila <awogbemila@chromium.org>
Date: Tue May 21 18:00:15 2024
[css-scroll-snap-2] Rename snapchanged to scrollsnapchange
Per the CSS working group resolution[1], snapchanged should be renamed
to scrollsnapchange. This patch changes file contents. A follow-up patch
will change file names and directory names.
[1]https://github.com/w3c/csswg-drafts/issues/9697#issuecomment-2089278615
Bug: 40273052, 338290502
Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5538748
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303892}
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/dom/document.h
M third_party/blink/renderer/core/dom/events/event_target.h
M third_party/blink/renderer/core/dom/events/event_target_test.cc
M third_party/blink/renderer/core/dom/global_event_handlers.idl
M third_party/blink/renderer/core/events/event_type_names.json5
M third_party/blink/renderer/core/events/event_util.cc
M third_party/blink/renderer/core/frame/root_frame_viewport.cc
M third_party/blink/renderer/core/frame/root_frame_viewport.h
M third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
M third_party/blink/renderer/core/html/html_attribute_names.json5
M third_party/blink/renderer/core/html/html_element.cc
M third_party/blink/renderer/core/page/page_animator.cc
M third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
M third_party/blink/renderer/core/scroll/scrollable_area.cc
M third_party/blink/renderer/core/scroll/scrollable_area.h
M third_party/blink/renderer/core/scroll/snap_event.h
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/external/WPT_BASE_MANIFEST_8.json
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/user-scroll-common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snap-events-with-pseudo-target.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-after-layout-change.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-interrupted-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-same-targets-after-layout-changed.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-scrolling-non-snapping-axis.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-with-proximity-strictness.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapevents-at-document-bubble-to-window.html
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
https://chromium-review.googlesource.com/5538748
Branch: main
commit 090dfd92b94d55c2a0ac9bd3d497e73f4d6b6b70
Author: David Awogbemila <awogbemila@chromium.org>
Date: Tue May 21 18:00:15 2024
[css-scroll-snap-2] Rename snapchanged to scrollsnapchange
Per the CSS working group resolution[1], snapchanged should be renamed
to scrollsnapchange. This patch changes file contents. A follow-up patch
will change file names and directory names.
[1]
Bug: 40273052, 338290502
Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619
Reviewed-on:
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303892}
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/dom/document.h
M third_party/blink/renderer/core/dom/events/event_target.h
M third_party/blink/renderer/core/dom/events/event_target_test.cc
M third_party/blink/renderer/core/dom/global_event_handlers.idl
M third_party/blink/renderer/core/events/event_type_names.json5
M third_party/blink/renderer/core/events/event_util.cc
M third_party/blink/renderer/core/frame/root_frame_viewport.cc
M third_party/blink/renderer/core/frame/root_frame_viewport.h
M third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
M third_party/blink/renderer/core/html/html_attribute_names.json5
M third_party/blink/renderer/core/html/html_element.cc
M third_party/blink/renderer/core/page/page_animator.cc
M third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
M third_party/blink/renderer/core/scroll/scrollable_area.cc
M third_party/blink/renderer/core/scroll/scrollable_area.h
M third_party/blink/renderer/core/scroll/snap_event.h
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/external/WPT_BASE_MANIFEST_8.json
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/resources/user-scroll-common.js
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snap-events-with-pseudo-target.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-after-layout-change.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-interrupted-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-same-targets-after-layout-changed.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-scrolling-non-snapping-axis.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapchanged/snapchanged-with-proximity-strictness.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/snapevents-at-document-bubble-to-window.html
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
ap...@google.com
Project: chromium/src
Branch: main
commit 93920a328b8e1ba6098b4a6e393d51d100880d70
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed May 22 19:38:52 2024
[css-scroll-snap-2] Rename snapchanged to scrollsnapchange
Per the CSS working group resolution[1], snapchanged should be
renamed to scrollsnapchange. This patch changes the relevant file
names and directory names.
[1]https://github.com/w3c/csswg-drafts/issues/9697#issuecomment-2089278615
Bug: 40273052, 338290502
Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5538749
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304613}
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-after-layout-change.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-interrupted-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-user-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-same-targets-after-layout-changed.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-scrolling-non-snapping-axis.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-with-proximity-strictness.tentative.html
https://chromium-review.googlesource.com/5538749
Branch: main
commit 93920a328b8e1ba6098b4a6e393d51d100880d70
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed May 22 19:38:52 2024
[css-scroll-snap-2] Rename snapchanged to scrollsnapchange
Per the CSS working group resolution[1], snapchanged should be
renamed to scrollsnapchange. This patch changes the relevant file
names and directory names.
[1]
Bug: 40273052, 338290502
Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401
Reviewed-on:
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304613}
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-after-layout-change.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-interrupted-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-programmatic-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-programmatic-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-user-root-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-on-user-scroll.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-same-targets-after-layout-changed.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-scrolling-non-snapping-axis.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-scroll-snap-2/scrollsnapchange/scrollsnapchange-with-proximity-strictness.tentative.html
ap...@google.com
Project: chromium/src
Branch: main
commit 5458f67d49177e0449da0714fb8f447cd710aaf1
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed Aug 21 16:09:44 2024
Enable snap events in stable
Snap events[1] are JavaScript events that fire in response to a change
in the element(s) which a scroll-snap[2] container tries to align with.
The explainer[3] contains example usage.
Update FPWD[4] is now published.
Intent-To-Ship:https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA6pwF6jFwLW-0t46A-AKkDUVkdKc-ssqv26V3UqM6S8FJ51zA%40mail.gmail.com
[1]https://www.w3.org/TR/css-scroll-snap-2/#snap-events
[2]https://www.w3.org/TR/css-scroll-snap-1/
[3]https://github.com/argyleink/ScrollSnapExplainers/tree/main/js-snapChanged
[4]https://www.w3.org/TR/2024/WD-css-scroll-snap-2-20240723/
Bug: 40273052
Change-Id: Ic321a81460d0084590e4d155c2b7bc2b3713b384
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5655871
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1344831}
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
https://chromium-review.googlesource.com/5655871
Branch: main
commit 5458f67d49177e0449da0714fb8f447cd710aaf1
Author: David Awogbemila <awogbemila@chromium.org>
Date: Wed Aug 21 16:09:44 2024
Enable snap events in stable
Snap events[1] are JavaScript events that fire in response to a change
in the element(s) which a scroll-snap[2] container tries to align with.
The explainer[3] contains example usage.
Update FPWD[4] is now published.
Intent-To-Ship:
[1]
[2]
[3]
[4]
Bug: 40273052
Change-Id: Ic321a81460d0084590e4d155c2b7bc2b3713b384
Reviewed-on:
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1344831}
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
aw...@google.com
We are requesting a merge into M129 for the patch in comment in
pe...@google.com
Merge approved: your change passed merge requirements and is auto-approved for M129. Please go ahead and merge the CL to branch 6668 (refs/branch-heads/6668) manually. Please contact milestone owner if you have questions.
Merge instructions:
ap...@google.com
Project: chromium/src
Branch: refs/branch-heads/6668
commit 3f8f65b66d62b0f3879d2f85e30e9e1331b6170f
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Aug 22 18:54:05 2024
Enable snap events in stable
Snap events[1] are JavaScript events that fire in response to a change
in the element(s) which a scroll-snap[2] container tries to align with.
The explainer[3] contains example usage.
Update FPWD[4] is now published.
Intent-To-Ship:https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA6pwF6jFwLW-0t46A-AKkDUVkdKc-ssqv26V3UqM6S8FJ51zA%40mail.gmail.com
[1]https://www.w3.org/TR/css-scroll-snap-2/#snap-events
[2]https://www.w3.org/TR/css-scroll-snap-1/
[3]https://github.com/argyleink/ScrollSnapExplainers/tree/main/js-snapChanged
[4]https://www.w3.org/TR/2024/WD-css-scroll-snap-2-20240723/
(cherry picked from commit 5458f67d49177e0449da0714fb8f447cd710aaf1)
Bug: 40273052
Change-Id: Ic321a81460d0084590e4d155c2b7bc2b3713b384
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5655871
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1344831}
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5807045
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/branch-heads/6668@{#143}
Cr-Branched-From: 05bc664984ca075216b7f2198c88b9725bfa1b9b-refs/heads/main@{#1343869}
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
https://chromium-review.googlesource.com/5807045
Branch: refs/branch-heads/6668
commit 3f8f65b66d62b0f3879d2f85e30e9e1331b6170f
Author: David Awogbemila <awogbemila@chromium.org>
Date: Thu Aug 22 18:54:05 2024
Enable snap events in stable
Snap events[1] are JavaScript events that fire in response to a change
in the element(s) which a scroll-snap[2] container tries to align with.
The explainer[3] contains example usage.
Update FPWD[4] is now published.
Intent-To-Ship:
[1]
[2]
[3]
[4]
(cherry picked from commit 5458f67d49177e0449da0714fb8f447cd710aaf1)
Bug: 40273052
Change-Id: Ic321a81460d0084590e4d155c2b7bc2b3713b384
Reviewed-on:
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1344831}
Reviewed-on:
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/branch-heads/6668@{#143}
Cr-Branched-From: 05bc664984ca075216b7f2198c88b9725bfa1b9b-refs/heads/main@{#1343869}
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
Description
This is a tracking bug for the implementation of JavaScript events, scrollsnapchange and scrollsnapchanging defined in the scroll-snap-2 spec[1].
[1]https://drafts.csswg.org/css-scroll-snap-2/#snap-events