Fixed
Status Update
No update yet.
Comments
ha...@chromium.org
Also hitting CFI errors from vector, e.g. from
[ RUN ] AllocationEventDispatcherInternalTest.VerifyAllocatorShimHooksTriggerCorrectly_aligned_free_function
../../third_party/libc++/src/include/__vector/vector.h:790:16: runtime error: control flow integrity check for type 'testing::internal::MatcherBase<const base::allocator::dispatcher::FreeNotificationData &>' failed during cast to unrelated type (vtable address 0xabababababababab)
0xabababababababab: note: invalid vtable
<memory cannot be printed>
../../third_party/libc++/src/include/__vector/vector.h:790:16: note: check failed in /b/s/w/ir/out/3252-linux_chromium_/base_unittests, vtable located in (unknown)
#0 0x55f54a6e0d60 in std::__Cr::vector<testing::Matcher<base::allocator::dispatcher::FreeNotificationData const&>, std::__Cr::allocator<testing::Matcher<base::allocator::dispatcher::FreeNotificationData const&>>>::__add_alignment_assumption(testing::Matcher<base::allocator::dispatcher::FreeNotificationData const&>*) ./../../third_party/libc++/src/include/__vector/vector.h:790:16
#1 0x55f54a6e0c11 in std::__Cr::vector<testing::Matcher<base::allocator::dispatcher::FreeNotificationData const&>, std::__Cr::allocator<testing::Matcher<base::allocator::dispatcher::FreeNotificationData const&>>>::end() const ./../../third_party/libc++/src/include/__vector/vector.h:358:24
Commented on
ap...@google.com
Project: chromium/src
Branch: main
Author: Hans Wennborg <
Link:
Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)
Expand for full commit details
Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2e25154d49c2..12150825ca73
2025-01-23 nikolasklauser@berlin.de [libc++] Inline basic_streambuf functions (#123379)
2025-01-23 nikolasklauser@berlin.de [libc++] Remove a few unused includes (#124025)
2025-01-23 brad@comstyle.com [libc++] Remove support for Android 4 and older (#124062)
2025-01-22 nikolasklauser@berlin.de [libc++] Avoid unnecessary instantiations for __copy_cvref_t (#123718)
2025-01-21 de34@live.cn [libc++] Fix input-only range handling for `vector` (#116157)
2025-01-21 de34@live.cn [libc++] Fix input-only range handling for `basic_string` (#116890)
2025-01-21 winner245@hotmail.com [libc++] Fix no-op shrink_to_fit for vector<bool> (#120495)
2025-01-21 nikolasklauser@berlin.de [libc++] Document that internal aliases should be marked _LIBCPP_NODEBUG (#122175)
2025-01-21 oleksandr.tarasiuk@outlook.com [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (#121419)
2025-01-20 ldionne.2@gmail.com [libc++] Another _LIBCPP_NODEBUG fix
2025-01-20 ldionne.2@gmail.com [libc++] Add missing _LIBCPP_NODEBUG on internal alias
2025-01-20 nikolasklauser@berlin.de [libc++] Define an internal API for std::invoke and friends (#116637)
2025-01-20 1108560+ddcc@users.noreply.github.com [libc++] Fix vector sanitization annotations on destruction (#121031)
2025-01-19 de34@live.cn [libc++][Docs] Mark P1353R0 as complete (#123020)
2025-01-19 vvereschaka@accesssoftek.com [libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. (#123449)
2025-01-18 hui.xie1990@gmail.com [libc++] remove yield from atomic::wait (#120012)
2025-01-17 ldionne.2@gmail.com [libc++] Don't implement <stdatomic.h> before C++23 (#123130)
2025-01-17 nikolasklauser@berlin.de [libc++] Enable _LIBCPP_NODEBUG again (#123318)
2025-01-17 ldionne.2@gmail.com [libc++] Allow passing arguments to GoogleBenchmark's compare.py tool
2025-01-16 ldionne.2@gmail.com [libc++] Remove string benchmark for internal function
2025-01-16 ldionne.2@gmail.com [libc++] Rename libstdc++ test parameters to allow setting them in LIBCXX_TEST_PARAMS
2025-01-16 flo@fhahn.com [libc++] Add assumption for align of begin and end pointers of vector. (#108961)
2025-01-16 rprichard@google.com [libc++][Android] XFAIL some tests for mblen/towctrans/wctrans (#116147)
2025-01-16 ldionne.2@gmail.com [libc++] Clarify the release note for uncaught_exception removal and deprecation (#123118)
2025-01-15 martin@martin.st [libcxx] [test] Add a test for the range of file offsets (#122798)
2025-01-14 nikolasklauser@berlin.de [libc++] Simplify when the sized global deallocations overloads are available (#114667)
2025-01-14 kstoimenov@google.com Revert "[libc++] Stop copying headers to the build directory (#115380)"
2025-01-14 ldionne.2@gmail.com [libc++] Remove unused _LIBCPP_HAS_NO_TREE_BARRIER macro and associated dead code (#122769)
2025-01-14 winner245@hotmail.com [libc++] Optimize input_iterator-pair `insert` for std::vector (#113768)
2025-01-14 winner245@hotmail.com [libc++] Fix ambiguity due to non-uglified member typedefs (#121664)
2025-01-14 de34@live.cn [libc++] Fix `tuple_cat` for element with unconstrained constructor (#122433)
2025-01-14 paulxicao7@gmail.com [libc++] Make std::stable_sort constexpr friendly (#110320)
2025-01-14 alexrichardson@google.com [libc++] Stop copying headers to the build directory (#115380)
2025-01-14 martin@martin.st [libcxx] Reindent a section of a CMake file. NFC. (#122800)
2025-01-13 winner245@hotmail.com [libc++][test] Add exception tests for vector capacity operations (#118141)
2025-01-13 perry@ca.ibm.com [libc++][z/OS] __cxx03 subdir was added by mistake (#122763)
2025-01-13 brotcrunsher@hotmail.de [libcxx] Don't hold the lock when calling notify_* on gates in std::shared_mutex (#107876)
2025-01-13 ldionne.2@gmail.com [libc++] Redefine Fuchsia locale base support on top of the new API (#122489)
2025-01-13 de34@live.cn [libc++] Deprecate extension `packaged_task::result_type` (#122600)
2025-01-13 ldionne.2@gmail.com [libc++][NFC] Use uint32_t instead of __uint32_t on Apple (#122356)
2025-01-13 ldionne.2@gmail.com [libc++] Pass type information down to __libcpp_allocate (#118837)
2025-01-13 hui.xie1990@gmail.com [libc++] Replace stable_sort with sort in flat_map (#121431)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libcxx-chromium
Please CC hans@chromium.org,thakis@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: 389897610, 391750836, 392652315
Binary-Size: arm64 growth probably temporary until new profiles are generated
Change-Id: I5ea0b21a9a6b275452b1cc5135e272b06c785738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6193275
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1412603}
Files:
- M
DEPS - M
buildtools/deps_revisions.gni - M
third_party/abseil-cpp/symbols_arm64_dbg.def - M
third_party/abseil-cpp/symbols_x64_dbg.def - M
third_party/abseil-cpp/symbols_x64_rel_asan.def - M
third_party/abseil-cpp/symbols_x86_dbg.def - M
third_party/fast_float/BUILD.gn - M
third_party/libc++/src - M
third_party/pthreadpool/chromium/jobs.cc - M
tools/cfi/ignores.txt
Hash: f7b2f0bc02d3e21acfc1040c23e2aa0845031b46
Date: Tue Jan 28 15:38:11 2025
ap...@google.com
Project: chromium/src
Branch: main
Author: Sparik Hayrapetyan <
Link:
Revert "Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)"
Expand for full commit details
Revert "Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)"
This reverts commit f7b2f0bc02d3e21acfc1040c23e2aa0845031b46.
Reason for revert: resulting in https://crbug.com/392929845 and most probably also in https://crbug.com/393009392
Original change's description:
> Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)
>
> https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2e25154d49c2..12150825ca73
>
> 2025-01-23 nikolasklauser@berlin.de [libc++] Inline basic_streambuf functions (#123379)
> 2025-01-23 nikolasklauser@berlin.de [libc++] Remove a few unused includes (#124025)
> 2025-01-23 brad@comstyle.com [libc++] Remove support for Android 4 and older (#124062)
> 2025-01-22 nikolasklauser@berlin.de [libc++] Avoid unnecessary instantiations for __copy_cvref_t (#123718)
> 2025-01-21 de34@live.cn [libc++] Fix input-only range handling for `vector` (#116157)
> 2025-01-21 de34@live.cn [libc++] Fix input-only range handling for `basic_string` (#116890)
> 2025-01-21 winner245@hotmail.com [libc++] Fix no-op shrink_to_fit for vector<bool> (#120495)
> 2025-01-21 nikolasklauser@berlin.de [libc++] Document that internal aliases should be marked _LIBCPP_NODEBUG (#122175)
> 2025-01-21 oleksandr.tarasiuk@outlook.com [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (#121419)
> 2025-01-20 ldionne.2@gmail.com [libc++] Another _LIBCPP_NODEBUG fix
> 2025-01-20 ldionne.2@gmail.com [libc++] Add missing _LIBCPP_NODEBUG on internal alias
> 2025-01-20 nikolasklauser@berlin.de [libc++] Define an internal API for std::invoke and friends (#116637)
> 2025-01-20 1108560+ddcc@users.noreply.github.com [libc++] Fix vector sanitization annotations on destruction (#121031)
> 2025-01-19 de34@live.cn [libc++][Docs] Mark P1353R0 as complete (#123020)
> 2025-01-19 vvereschaka@accesssoftek.com [libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. (#123449)
> 2025-01-18 hui.xie1990@gmail.com [libc++] remove yield from atomic::wait (#120012)
> 2025-01-17 ldionne.2@gmail.com [libc++] Don't implement <stdatomic.h> before C++23 (#123130)
> 2025-01-17 nikolasklauser@berlin.de [libc++] Enable _LIBCPP_NODEBUG again (#123318)
> 2025-01-17 ldionne.2@gmail.com [libc++] Allow passing arguments to GoogleBenchmark's compare.py tool
> 2025-01-16 ldionne.2@gmail.com [libc++] Remove string benchmark for internal function
> 2025-01-16 ldionne.2@gmail.com [libc++] Rename libstdc++ test parameters to allow setting them in LIBCXX_TEST_PARAMS
> 2025-01-16 flo@fhahn.com [libc++] Add assumption for align of begin and end pointers of vector. (#108961)
> 2025-01-16 rprichard@google.com [libc++][Android] XFAIL some tests for mblen/towctrans/wctrans (#116147)
> 2025-01-16 ldionne.2@gmail.com [libc++] Clarify the release note for uncaught_exception removal and deprecation (#123118)
> 2025-01-15 martin@martin.st [libcxx] [test] Add a test for the range of file offsets (#122798)
> 2025-01-14 nikolasklauser@berlin.de [libc++] Simplify when the sized global deallocations overloads are available (#114667)
> 2025-01-14 kstoimenov@google.com Revert "[libc++] Stop copying headers to the build directory (#115380)"
> 2025-01-14 ldionne.2@gmail.com [libc++] Remove unused _LIBCPP_HAS_NO_TREE_BARRIER macro and associated dead code (#122769)
> 2025-01-14 winner245@hotmail.com [libc++] Optimize input_iterator-pair `insert` for std::vector (#113768)
> 2025-01-14 winner245@hotmail.com [libc++] Fix ambiguity due to non-uglified member typedefs (#121664)
> 2025-01-14 de34@live.cn [libc++] Fix `tuple_cat` for element with unconstrained constructor (#122433)
> 2025-01-14 paulxicao7@gmail.com [libc++] Make std::stable_sort constexpr friendly (#110320)
> 2025-01-14 alexrichardson@google.com [libc++] Stop copying headers to the build directory (#115380)
> 2025-01-14 martin@martin.st [libcxx] Reindent a section of a CMake file. NFC. (#122800)
> 2025-01-13 winner245@hotmail.com [libc++][test] Add exception tests for vector capacity operations (#118141)
> 2025-01-13 perry@ca.ibm.com [libc++][z/OS] __cxx03 subdir was added by mistake (#122763)
> 2025-01-13 brotcrunsher@hotmail.de [libcxx] Don't hold the lock when calling notify_* on gates in std::shared_mutex (#107876)
> 2025-01-13 ldionne.2@gmail.com [libc++] Redefine Fuchsia locale base support on top of the new API (#122489)
> 2025-01-13 de34@live.cn [libc++] Deprecate extension `packaged_task::result_type` (#122600)
> 2025-01-13 ldionne.2@gmail.com [libc++][NFC] Use uint32_t instead of __uint32_t on Apple (#122356)
> 2025-01-13 ldionne.2@gmail.com [libc++] Pass type information down to __libcpp_allocate (#118837)
> 2025-01-13 hui.xie1990@gmail.com [libc++] Replace stable_sort with sort in flat_map (#121431)
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/libcxx-chromium
> Please CC hans@chromium.org,thakis@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Bug: 389897610, 391750836, 392652315
> Binary-Size: arm64 growth probably temporary until new profiles are generated
> Change-Id: I5ea0b21a9a6b275452b1cc5135e272b06c785738
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6193275
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1412603}
Bug: 389897610, 391750836, 392652315
Change-Id: Ib981998001048a486fbaba778c86cede097f0bd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6212500
Commit-Queue: Sparik Hayrapetyan <ust@google.com>
Owners-Override: Sparik Hayrapetyan <ust@google.com>
Auto-Submit: Sparik Hayrapetyan <ust@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1412783}
Files:
- M
DEPS - M
buildtools/deps_revisions.gni - M
third_party/abseil-cpp/symbols_arm64_dbg.def - M
third_party/abseil-cpp/symbols_x64_dbg.def - M
third_party/abseil-cpp/symbols_x64_rel_asan.def - M
third_party/abseil-cpp/symbols_x86_dbg.def - M
third_party/fast_float/BUILD.gn - M
third_party/libc++/src - M
third_party/pthreadpool/chromium/jobs.cc - M
tools/cfi/ignores.txt
Hash: 3227dce93b362ee671197d95e33de5cb15a4fc3f
Date: Wed Jan 29 02:02:32 2025
ap...@google.com
Project: chromium/src
Branch: main
Author: Hans Wennborg <
Link:
Reland "Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)"
Expand for full commit details
Reland "Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)"
This is a reland of commit f7b2f0bc02d3e21acfc1040c23e2aa0845031b46
It was previously reverted due to clang crashing: crbug.com/392929845
That was fixed in the latest clang roll: crrev.com/1417174
Original change's description:
> Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)
>
> https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2e25154d49c2..12150825ca73
>
> 2025-01-23 nikolasklauser@berlin.de [libc++] Inline basic_streambuf functions (#123379)
> 2025-01-23 nikolasklauser@berlin.de [libc++] Remove a few unused includes (#124025)
> 2025-01-23 brad@comstyle.com [libc++] Remove support for Android 4 and older (#124062)
> 2025-01-22 nikolasklauser@berlin.de [libc++] Avoid unnecessary instantiations for __copy_cvref_t (#123718)
> 2025-01-21 de34@live.cn [libc++] Fix input-only range handling for `vector` (#116157)
> 2025-01-21 de34@live.cn [libc++] Fix input-only range handling for `basic_string` (#116890)
> 2025-01-21 winner245@hotmail.com [libc++] Fix no-op shrink_to_fit for vector<bool> (#120495)
> 2025-01-21 nikolasklauser@berlin.de [libc++] Document that internal aliases should be marked _LIBCPP_NODEBUG (#122175)
> 2025-01-21 oleksandr.tarasiuk@outlook.com [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (#121419)
> 2025-01-20 ldionne.2@gmail.com [libc++] Another _LIBCPP_NODEBUG fix
> 2025-01-20 ldionne.2@gmail.com [libc++] Add missing _LIBCPP_NODEBUG on internal alias
> 2025-01-20 nikolasklauser@berlin.de [libc++] Define an internal API for std::invoke and friends (#116637)
> 2025-01-20 1108560+ddcc@users.noreply.github.com [libc++] Fix vector sanitization annotations on destruction (#121031)
> 2025-01-19 de34@live.cn [libc++][Docs] Mark P1353R0 as complete (#123020)
> 2025-01-19 vvereschaka@accesssoftek.com [libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. (#123449)
> 2025-01-18 hui.xie1990@gmail.com [libc++] remove yield from atomic::wait (#120012)
> 2025-01-17 ldionne.2@gmail.com [libc++] Don't implement <stdatomic.h> before C++23 (#123130)
> 2025-01-17 nikolasklauser@berlin.de [libc++] Enable _LIBCPP_NODEBUG again (#123318)
> 2025-01-17 ldionne.2@gmail.com [libc++] Allow passing arguments to GoogleBenchmark's compare.py tool
> 2025-01-16 ldionne.2@gmail.com [libc++] Remove string benchmark for internal function
> 2025-01-16 ldionne.2@gmail.com [libc++] Rename libstdc++ test parameters to allow setting them in LIBCXX_TEST_PARAMS
> 2025-01-16 flo@fhahn.com [libc++] Add assumption for align of begin and end pointers of vector. (#108961)
> 2025-01-16 rprichard@google.com [libc++][Android] XFAIL some tests for mblen/towctrans/wctrans (#116147)
> 2025-01-16 ldionne.2@gmail.com [libc++] Clarify the release note for uncaught_exception removal and deprecation (#123118)
> 2025-01-15 martin@martin.st [libcxx] [test] Add a test for the range of file offsets (#122798)
> 2025-01-14 nikolasklauser@berlin.de [libc++] Simplify when the sized global deallocations overloads are available (#114667)
> 2025-01-14 kstoimenov@google.com Revert "[libc++] Stop copying headers to the build directory (#115380)"
> 2025-01-14 ldionne.2@gmail.com [libc++] Remove unused _LIBCPP_HAS_NO_TREE_BARRIER macro and associated dead code (#122769)
> 2025-01-14 winner245@hotmail.com [libc++] Optimize input_iterator-pair `insert` for std::vector (#113768)
> 2025-01-14 winner245@hotmail.com [libc++] Fix ambiguity due to non-uglified member typedefs (#121664)
> 2025-01-14 de34@live.cn [libc++] Fix `tuple_cat` for element with unconstrained constructor (#122433)
> 2025-01-14 paulxicao7@gmail.com [libc++] Make std::stable_sort constexpr friendly (#110320)
> 2025-01-14 alexrichardson@google.com [libc++] Stop copying headers to the build directory (#115380)
> 2025-01-14 martin@martin.st [libcxx] Reindent a section of a CMake file. NFC. (#122800)
> 2025-01-13 winner245@hotmail.com [libc++][test] Add exception tests for vector capacity operations (#118141)
> 2025-01-13 perry@ca.ibm.com [libc++][z/OS] __cxx03 subdir was added by mistake (#122763)
> 2025-01-13 brotcrunsher@hotmail.de [libcxx] Don't hold the lock when calling notify_* on gates in std::shared_mutex (#107876)
> 2025-01-13 ldionne.2@gmail.com [libc++] Redefine Fuchsia locale base support on top of the new API (#122489)
> 2025-01-13 de34@live.cn [libc++] Deprecate extension `packaged_task::result_type` (#122600)
> 2025-01-13 ldionne.2@gmail.com [libc++][NFC] Use uint32_t instead of __uint32_t on Apple (#122356)
> 2025-01-13 ldionne.2@gmail.com [libc++] Pass type information down to __libcpp_allocate (#118837)
> 2025-01-13 hui.xie1990@gmail.com [libc++] Replace stable_sort with sort in flat_map (#121431)
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/libcxx-chromium
> Please CC hans@chromium.org,thakis@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Bug: 389897610, 391750836, 392652315
> Binary-Size: arm64 growth probably temporary until new profiles are generated
> Change-Id: I5ea0b21a9a6b275452b1cc5135e272b06c785738
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6193275
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1412603}
Cq-Include-Trybots: luci.chromium.try:win-rel-cft
Binary-Size: arm64 growth temporary until new profiles are generated
Bug: 389897610, 392652315
Change-Id: Ieef178042cfc4cf11f778fafbc0c35b947d3f4f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6247617
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418195}
Files:
- M
DEPS - M
buildtools/deps_revisions.gni - M
third_party/abseil-cpp/symbols_arm64_dbg.def - M
third_party/abseil-cpp/symbols_x64_dbg.def - M
third_party/abseil-cpp/symbols_x64_rel_asan.def - M
third_party/abseil-cpp/symbols_x86_dbg.def - M
third_party/libc++/src - M
tools/cfi/ignores.txt
Hash: add057332229b6bda7c050cdd1d2237734a395fa
Date: Mon Feb 10 09:06:23 2025
Description
Fromhttps://chromium-review.googlesource.com/c/chromium/src/+/6193275 / https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_cfi_rel_ng/9621/overview
The roll includeshttps://github.com/llvm/llvm-project/pull/118837 which added a cast to the line we're now failing at:
I think we can suppress it in
tools/cfi/ignores.txtfor now, but maybe this function should have an_LIBCPP_NO_CFIannotation?